Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add eACL rules to System group #825

Merged

Conversation

smallhive
Copy link
Contributor

closes #817

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #825 (bb77e30) into master (d65708a) will decrease coverage by 0.28%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
- Coverage   34.33%   34.05%   -0.28%     
==========================================
  Files          61       61              
  Lines       10486    10472      -14     
==========================================
- Hits         3600     3566      -34     
- Misses       6485     6505      +20     
  Partials      401      401              
Files Changed Coverage Δ
api/handler/acl.go 64.67% <ø> (-2.38%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smallhive smallhive marked this pull request as ready for review September 14, 2023 04:36
@roman-khimov roman-khimov merged commit 9c76499 into master Sep 14, 2023
11 of 12 checks passed
@roman-khimov roman-khimov deleted the 817-do-not-add-eacl-rules-related-to-system-group branch September 14, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not add eACL rules related to SYSTEM group
2 participants