Preallocate buffers to object uploads #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallhive
force-pushed
the
833-optimize-allocations
branch
from
015b913
to
3997b60
Compare
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
- Coverage 34.05% 33.86% -0.19%
==========================================
Files 61 62 +1
Lines 10472 10529 +57
==========================================
Hits 3566 3566
- Misses 6505 6562 +57
Partials 401 401
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
smallhive
force-pushed
the
833-optimize-allocations
branch
3 times, most recently
from
27163a8
to
ec47db0
Compare
roman-khimov
reviewed
Oct 4, 2023
smallhive
force-pushed
the
833-optimize-allocations
branch
from
ce7d2d8
to
a5eab85
Compare
roman-khimov
reviewed
Oct 5, 2023
smallhive
force-pushed
the
833-optimize-allocations
branch
2 times, most recently
from
5641ff7
to
86aa06f
Compare
closes #833 Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
833-optimize-allocations
branch
3 times, most recently
from
4253ce3
to
f0f5a22
Compare
Supported |
The test requires real neofs cluster to execute. We are checking the object after uploading. Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
833-optimize-allocations
branch
from
f0f5a22
to
1ba680c
Compare
roman-khimov
approved these changes
Oct 9, 2023
| chunk := make([]byte, x.cfg.MaxObjectSize) | ||
| _, err = io.CopyBuffer(writer, prm.Payload, chunk) | ||
| data := x.buffers.Get() | ||
| chunk := data.(*[]byte) |
There was a problem hiding this comment.
Likely some Go 1.2X will bring generic-based Pool to us.
There was a problem hiding this comment.
It would be great, but 1.21 still have any version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #833