Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return correct error on lock configuration check #888

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Return correct error on lock configuration check #888

merged 2 commits into from
Nov 20, 2023

Conversation

smallhive
Copy link
Contributor

Closes #869.

@smallhive smallhive mentioned this pull request Oct 30, 2023
Closed
@smallhive smallhive force-pushed the 869-putobjectlockconfiguration-invalid branch from f26bcc1 to 72ab84d Compare October 30, 2023 13:04
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (340589f) 34.47% compared to head (a6a9094) 34.43%.
Report is 10 commits behind head on master.

Files Patch % Lines
api/handler/acl.go 36.84% 11 Missing and 1 partial ⚠️
api/auth/center.go 0.00% 3 Missing ⚠️
api/layer/cors.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
- Coverage   34.47%   34.43%   -0.04%     
==========================================
  Files          62       62              
  Lines       10583    10594      +11     
==========================================
  Hits         3648     3648              
- Misses       6529     6540      +11     
  Partials      406      406

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roman-khimov
roman-khimov previously approved these changes Oct 30, 2023
View reviewed changes
@smallhive smallhive force-pushed the 869-putobjectlockconfiguration-invalid branch from 72ab84d to ad2e250 Compare November 2, 2023 04:29
@smallhive smallhive marked this pull request as ready for review November 2, 2023 04:29
roman-khimov
roman-khimov reviewed Nov 8, 2023
View reviewed changes
api/handler/locking.go Outdated Show resolved Hide resolved
@smallhive smallhive force-pushed the 869-putobjectlockconfiguration-invalid branch from ad2e250 to 9b71a93 Compare November 20, 2023 06:21
@smallhive smallhive force-pushed the 869-putobjectlockconfiguration-invalid branch from 9b71a93 to a6a9094 Compare November 20, 2023 07:37
@roman-khimov roman-khimov merged commit 6541c61 into master Nov 20, 2023
14 of 16 checks passed
@roman-khimov roman-khimov deleted the 869-putobjectlockconfiguration-invalid branch November 20, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PutObjectLockConfiguration: invalid values should be handled properly
2 participants
@smallhive @roman-khimov