Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

927 go 122 upgrade check list #994

Merged
merged 9 commits into from
Sep 3, 2024
Merged

927 go 122 upgrade check list #994

merged 9 commits into from
Sep 3, 2024

Conversation

smallhive
Copy link
Contributor

Closes #927

roman-khimov
roman-khimov requested changes Sep 3, 2024
View reviewed changes
api/auth/center_test.go Outdated Show resolved Hide resolved
api/handler/encryption_test.go Show resolved Hide resolved
api/handler/object_list_test.go Outdated Show resolved Hide resolved
api/handler/object_list_test.go Outdated Show resolved Hide resolved
api/handler/s3encoder.go Outdated Show resolved Hide resolved
internal/neofs/tree.go Outdated Show resolved Hide resolved
internal/neofs/tree.go Outdated Show resolved Hide resolved
internal/neofs/tree.go Outdated Show resolved Hide resolved
internal/neofs/tree.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@smallhive
*: Set Go 1.22 as minimum
4dc7770 
Closes #927.

Signed-off-by: Evgenii Baidakov <[email protected]>
roman-khimov
roman-khimov reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now slices.Concat commit is not just about Concat.

api/auth/center_test.go Outdated
@@ -432,7 +433,7 @@ func TestAwsEncodedWithRequest(t *testing.T) {
func chunkSlice(payload []byte, chunkSize int) [][]byte {
var result [][]byte

for i := 0; i < len(payload); i += chunkSize {
for i := range len(payload) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be correct, we were iterating with += chunkSize steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, updated

@smallhive
*: Update for loop ranging
9a4d789 
Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive
*: Use slices package instead of append in some cases
aa2a6d7 
Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive
go.mod: Update github.com/minio/sio to v0.4.1
1c54695 
Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive
go.mod: Update github.com/nats-io/nats.go to v1.37.0
225e03c 
Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive
go.mod: Update github.com/nspcc-dev/tzhash to v1.8.2
bad30de 
Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive
go.mod: Update github.com/prometheus/client_golang to v1.20.2
1668bed 
Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive
go.mod: github.com/urfave/cli/v2 to v2.27.4
d6792d3 
Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive
linter: Fix staticcheck
0e2cedd 
SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x.

Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive
Copy link
Contributor Author

Now slices.Concat commit is not just about Concat.

Renamed commit text

@roman-khimov roman-khimov merged commit 79f7414 into master Sep 3, 2024
15 of 16 checks passed
@roman-khimov roman-khimov deleted the 927-go-122-upgrade-check-list branch September 3, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go 1.22 upgrade check list
2 participants
@smallhive @roman-khimov