client: Provide method to copy binary object to the remote node #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Nov 15, 2023
•
cthulhu-rider
commented
- based on and blocked by Support binary object transmission neofs-api-go#436
This allows to use generators in benchmark tests and pass `testing.B`. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
feature/object-bin-replication
branch
3 times, most recently
from
a749881
to
b756c33
Compare
cthulhu-rider
force-pushed
the
feature/object-bin-replication
branch
5 times, most recently
from
73ff901
to
622d7ab
Compare
Sometimes there is a need to copy object encoded into Protocol Buffers binary format to the remote node. Previously, to do this, there was a need to almost completely decode the object. Faster binary transmission in demand during object replication (node-to-node) procedure performed by NeoFS storage nodes. Add `CopyBinaryObjectToNode` method that works with binary objects accessed through `io.ReadSeeker` stream. The method is optimized to encode different stream messages using single buffer. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
feature/object-bin-replication
branch
from
622d7ab
to
a60e899
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.