2022 11 07 merge with tradingview master #11
+28,680
−2,589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repeated attempts for the graphic test cases are now run in series instead of parallel (for the golden vs test screenshots). The tests are more reliable when run in series.
- Removing `getChartInstance` function and rather setting a variable on the global window. - Improved types within `screenshoter.ts`
…ests-ci Improve reliability of graphics tests
Invert filled area
…ly-visible-series-labels Fix price scale series labels cut off at edge
- Split checks into isChromiumBased and isWindows. - Moved windowsChrome variable out of the class into the module scope. - Increased size-limit because it exceeds the limit by 1 B
fix scroll speed on Windows chromium browsers
Add the ability to set width of the border of the crosshair marker tradingview#1059
# Conflicts: # .size-limit.js # src/api/chart-api.ts # src/gui/pane-widget.ts # src/views/pane/crosshair-marks-pane-view.ts
|
Type "value" missing at MouseEventParams from chart.subscribeCrosshairMove
This is what comes out in the console.
These are the differences between the compiled Types of the original Lightweight library and this one.
|
|
Hey guys, what's the status of this merge? |
|
Here is an updated fork people can reference if they'd like: https://github.com/rwitzlib/lightweight-charts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
PR checklist:
Overview of change:
Is there anything you'd like reviewers to focus on?