Simplifications and improvements for package building #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may impact builds on Debian 8, but that version has been out of support for over three years. I didnt test it, but since using this helper is the preferred method it may actually help builds on older versions.
TODO: - dont just ignore missing info, have something to fill it in even when the require arch binaries are missing
By switching to the "any" architecture, we no longer need to template the debian/control file. This simply claims that the package can be built on any known debian arch - which we currently think is true - so it will help future portability.
Continuing to try and simplify the build system, calculate the remaining two autoconf variables from the existing config.mak. For the moment, leave a configure and configure.ac file in place to allow any old build systems to continue to function without errors.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## dev #1144 +/- ##
=======================================
Coverage 21.66% 21.66%
=======================================
Files 46 46
Lines 8997 8997
=======================================
Hits 1949 1949
Misses 7048 7048 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly debian packages