fix Stack overflow caused by invalid write in ndpi_automa_match_strin… (

#2035) * minor fixes fixed 'handle leak' in ndpi_load_malicious_sha1_file and removed the redundant comparison ndpi_search_eaq * fix Stack overflow caused by invalid write in ndpi_automa_match_string_subprotocol * fix compile errors * fix --------- Co-authored-by: Ivan Kapranov <[email protected]>
ntop · Jul 6, 2023 · bdd295b · bdd295b
1 parent bb97890
commit bdd295b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/lib/ndpi_main.c b/src/lib/ndpi_main.c
@@ -8629,7 +8629,7 @@ static u_int16_t ndpi_automa_match_string_subprotocol(struct ndpi_detection_modu
 #ifdef NDPI_ENABLE_DEBUG_MESSAGES
   {
     char m[256];
-    int len = ndpi_min(sizeof(m), string_to_match_len);
+    u_int len = ndpi_min(sizeof(m) - 1, string_to_match_len);
 
     strncpy(m, string_to_match, len);
     m[len] = '\0';
@@ -8655,7 +8655,7 @@ static u_int16_t ndpi_automa_match_string_subprotocol(struct ndpi_detection_modu
 #ifdef NDPI_ENABLE_DEBUG_MESSAGES
   {
     char m[256];
-    int len = ndpi_min(sizeof(m), string_to_match_len);
+    u_int len = ndpi_min(sizeof(m) - 1, string_to_match_len);
 
     strncpy(m, string_to_match, len);
     m[len] = '\0';