Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP: fix extraction of filename #2046

Merged
merged 1 commit into from
Jul 13, 2023
Merged

HTTP: fix extraction of filename #2046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/protocols/http.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ static ndpi_protocol_category_t ndpi_http_check_content(struct ndpi_detection_mo
if(packet->content_disposition_line.len > 0) {
u_int8_t attachment_len = sizeof("attachment; filename");

if(packet->content_disposition_line.len > attachment_len) {
if(packet->content_disposition_line.len > attachment_len &&
strncmp((char *)packet->content_disposition_line.ptr, "attachment; filename", 20) == 0) {
u_int8_t filename_len = packet->content_disposition_line.len - attachment_len;
int i;

Expand Down
Loading