Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds on Windows #2580

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix builds on Windows #2580

merged 1 commit into from
Oct 1, 2024

Commits on Oct 1, 2024

  1. Fix builds on Windows

    Quick fix with latest Windows image on GitHub CI, where we got:
    ```
     ndpiReader.c:2860:38: error: '%s' directive output may be truncated writing up to 64 bytes into a region of size 63 [-Werror=format-truncation=]
     2860 |     snprintf(srcip, sizeof(srcip), "[%s]", flow->src_name);
          |                                      ^~
    ndpiReader.c:2860:5: note: 'snprintf' output between 3 and 67 bytes into a destination of size 64
     2860 |     snprintf(srcip, sizeof(srcip), "[%s]", flow->src_name);
          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ndpiReader.c:2861:38: error: '%s' directive output may be truncated writing up to 64 bytes into a region of size 63 [-Werror=format-truncation=]
     2861 |     snprintf(dstip, sizeof(dstip), "[%s]", flow->dst_name);
          |                                      ^~
    ndpiReader.c:2861:5: note: 'snprintf' output between 3 and 67 bytes into a destination of size 64
     2861 |     snprintf(dstip, sizeof(dstip), "[%s]", flow->dst_name);
          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ```
    IvanNardi committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bbde718 View commit details
    Browse the repository at this point in the history