Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent perpetual use of expired auth signature; remove superfluous API functions #567

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Prevent perpetual use of expired auth signature; remove superfluous API functions #567

merged 8 commits into from
Aug 27, 2024

Commits on Aug 20, 2024

  1. Add ability for IStorage to remove items.

    @derekpierre
    derekpierre committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    443922f View commit details
    Browse the repository at this point in the history

  2. Check whether prior auth signature is now expired (2h) before returni… 

    …ng; if expired remove from storage and regenerate it.
    @derekpierre
    derekpierre committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    be3af16 View commit details
    Browse the repository at this point in the history

  3. Add test for EIP4361AuthProvider storage expiry.

    @derekpierre
    derekpierre committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    09437cc View commit details
    Browse the repository at this point in the history

  4. Add test for SingleSignOnEIP4361AuthProvider.

    @derekpierre
    derekpierre committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    35019f3 View commit details
    Browse the repository at this point in the history

  5. Use a legit signer with the fakeProvider() test utility. 

    There is no need to have both fakeSigner() and fakeProvider() utilities. Only fakeProvider() is needed, and the signer can be obtained from the provider. It also better links the provider and signer.
    @derekpierre
    derekpierre committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    959f40e View commit details
    Browse the repository at this point in the history

  6. Update tests to obtain signer from fakeProvider() instead of using fa… 

    …keSigner() utility.
    @derekpierre
    derekpierre committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c53ea31 View commit details
    Browse the repository at this point in the history

  7. Exclude non-applicable files from code coverage reports.

    @derekpierre
    derekpierre committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    61176ca View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary taco api calls; one of which is no longer applicable.

    @derekpierre
    derekpierre committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    236f296 View commit details
    Browse the repository at this point in the history