Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump nucypher-contracts version to 0.23.0 #569

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

vzotova
Copy link
Member

@vzotova vzotova commented Aug 28, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR. List relevant API
changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

@vzotova vzotova self-assigned this Aug 28, 2024
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for taco-demo ready!

Name Link
🔨 Latest commit 9cbb904
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/66cf4a192126170008c4a49d
😎 Deploy Preview https://deploy-preview-569--taco-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for taco-nft-demo ready!

Name Link
🔨 Latest commit 9cbb904
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/66cf4a1992f8d10008ec1e99
😎 Deploy Preview https://deploy-preview-569--taco-nft-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.83784% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.45%. Comparing base (e8f9098) to head (9cbb904).
Report is 186 commits behind head on main.

Files Patch % Lines
...ackages/shared/src/contracts/agents/coordinator.ts 0.00% 2 Missing ⚠️
packages/taco/src/dkg.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #569       +/-   ##
===========================================
+ Coverage   23.12%   88.45%   +65.33%     
===========================================
  Files          62       59        -3     
  Lines       10175     6083     -4092     
  Branches      260      141      -119     
===========================================
+ Hits         2353     5381     +3028     
+ Misses       7763      702     -7061     
+ Partials       59        0       -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

@theref theref merged commit 5efda67 into nucypher:main Aug 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants