Restart downloads upon re-opening the application #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldo121
force-pushed
the
bug/1709-resume-download-on-restart
branch
from
40407c9
to
44e685b
Compare
waldo121
changed the title
waldo121
force-pushed
the
bug/1709-resume-download-on-restart
branch
from
44e685b
to
d028afd
Compare
waldo121
commented
Oct 10, 2024
Comment on lines
+106
to
+111
| if (track === undefined) { | ||
| // track is no longer in downloads, so nothing can be updated | ||
| return { | ||
| payload: downloads | ||
| }; | ||
| } |
There was a problem hiding this comment.
I randomly fell on this edge case, so I decided to handle it.
|
Thanks for fixing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1709
Since download progress is not recoverable from the electron store, I took the approach of restarting the started download instead of truly resuming it.