Bug/1675: Move the remove(X) button and interchange its position with select box #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nukeop
added
the
under review
|
Thanks for taking care of that, since those are cosmetic changes, if the CI passes I think this can be merged. The only feedback I have for you is that you've introduced some whitespace changes (due to formatting) which obscure the actual changes you made to the code, making it harder to review. At some point I plan to enforce Prettier everywhere, so that would not pass the pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1675
This pull request addresses the user interface issues related to the selection and remove button under Favourite Track.
Changes Made:
Testing:
Thank you for reviewing this pull request! :)