check type given to ImageCms.core.profile_tobytes instead of crashing

nulano · Jan 1, 2024 · 02fd759 · 02fd759
1 parent 2945ef7
commit 02fd759
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Tests/test_imagecms.py b/Tests/test_imagecms.py
@@ -489,6 +489,12 @@ def test_profile_typesafety():
     with pytest.raises(TypeError, match="Invalid type for Profile"):
         ImageCms.ImageCmsProfile(1).tobytes()
 
+    # also check core function
+    with pytest.raises(TypeError):
+        ImageCms.core.profile_tobytes(0)
+    with pytest.raises(TypeError):
+        ImageCms.core.profile_tobytes(1)
+
 
 def assert_aux_channel_preserved(mode, transform_in_place, preserved_channel):
     def create_test_image():

diff --git a/src/_imagingcms.c b/src/_imagingcms.c
@@ -143,7 +143,7 @@ cms_profile_tobytes(PyObject *self, PyObject *args) {
     cmsHPROFILE *profile;
 
     PyObject *ret;
-    if (!PyArg_ParseTuple(args, "O", &CmsProfile)) {
+    if (!PyArg_ParseTuple(args, "O!", &CmsProfile_Type, &CmsProfile)) {
         return NULL;
     }