Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide HLS format for Sound annotations. #164

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Sep 1, 2023

This addresses a small issue and sets an HLS mime type for the access filesets and their Canvas annotation body on Audio work Manifests. Previously lines 12-14 were only being applied to Video filesets.

const body = {
id: buildAnnotationBodyId(fileSet, workType),
type: bodyType,
format: isAudioVideo(bodyType)
? "application/x-mpegurl"
: fileSet.mime_type,
height: fileSet.height || 100,
width: fileSet.width || 100,
};

@mathewjordan mathewjordan self-assigned this Sep 1, 2023
@mathewjordan mathewjordan merged commit 019436b into deploy/staging Sep 1, 2023
2 checks passed
@mathewjordan mathewjordan deleted the 3901-av-mime-types branch September 1, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants