-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File set (video only) download API route #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbklein
force-pushed
the
3292-3-av-download
branch
from
October 11, 2023 19:17
c4c21a7
to
8b33559
Compare
kdid
force-pushed
the
3292-3-av-download
branch
from
October 13, 2023 14:30
4212eae
to
becd89e
Compare
kdid
force-pushed
the
3292-3-av-download
branch
from
October 13, 2023 14:32
becd89e
to
1be0a70
Compare
kdid
force-pushed
the
3292-3-av-download
branch
from
October 13, 2023 14:34
1be0a70
to
2890208
Compare
mbklein
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can the logging maybe be changed to use the
debug
package? I'm happy to help with that since I've set it up in other places. - Tests are failing for coverage reasons. Instead of lowering the minimum threshold, we should maybe use "ignore this file" tags at the top of the specific files, or configure the suite to ignore the
/lambdas/
directory.
kdid
force-pushed
the
3292-3-av-download
branch
from
October 13, 2023 15:18
2890208
to
310fb2a
Compare
kdid
force-pushed
the
3292-3-av-download
branch
from
October 13, 2023 15:28
310fb2a
to
13b637e
Compare
kdid
force-pushed
the
3292-3-av-download
branch
from
October 13, 2023 15:30
13b637e
to
2ed2bc7
Compare
mbklein
approved these changes
Oct 13, 2023
kdid
force-pushed
the
3292-3-av-download
branch
from
October 13, 2023 18:06
2ed2bc7
to
093ec1c
Compare
Co-authored-by: Michael Klein <[email protected]>
kdid
force-pushed
the
3292-3-av-download
branch
from
October 13, 2023 18:48
093ec1c
to
e8483b1
Compare
bmquinn
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/file-sets/{id}/download
routeSteps to test in developer environment
superUser
token from Meadow (dcApiToken
query)GET https://USER_PREFIX.dev.rdc.library.northwestern.edu:3002/file-sets/{id}/download?email={youremailhere}
with the Bearer Token