Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File set (video only) download API route #169

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Oct 9, 2023

Summary

Steps to test in developer environment

  • Follow startup instructions here: Running the API locally with state machine + lambdas (needed for AV download route)
  • Obtain the file set id for a video from your local Meadow environment.
  • Obtain a superUser token from Meadow (dcApiToken query)
  • Invoke GET https://USER_PREFIX.dev.rdc.library.northwestern.edu:3002/file-sets/{id}/download?email={youremailhere} with the Bearer Token
  • Observe immediate response
  • Monitor your email, click download link to obtain derivative video file
  • You can test error states by not using a token or sending a file set id that does not exist or is an image, or omitting the email. ETC...

@kdid kdid temporarily deployed to test October 11, 2023 14:20 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 11, 2023 15:52 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 11, 2023 19:02 — with GitHub Actions Inactive
@mbklein mbklein temporarily deployed to test October 11, 2023 19:17 — with GitHub Actions Inactive
@mbklein mbklein temporarily deployed to test October 11, 2023 20:08 — with GitHub Actions Inactive
@mbklein mbklein temporarily deployed to test October 11, 2023 20:11 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 12, 2023 15:50 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 12, 2023 16:49 — with GitHub Actions Inactive
@mbklein mbklein temporarily deployed to test October 12, 2023 17:36 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 12, 2023 19:44 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 12, 2023 20:42 — with GitHub Actions Inactive
@kdid kdid changed the title 3292 3 av download File set (video only) download API route Oct 13, 2023
@kdid kdid temporarily deployed to test October 13, 2023 13:49 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 13, 2023 14:03 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 13, 2023 14:30 — with GitHub Actions Inactive
@kdid kdid marked this pull request as ready for review October 13, 2023 14:31
@kdid kdid requested review from mbklein and bmquinn October 13, 2023 14:31
@kdid kdid temporarily deployed to test October 13, 2023 14:32 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 13, 2023 14:34 — with GitHub Actions Inactive
Copy link
Contributor

@mbklein mbklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can the logging maybe be changed to use the debug package? I'm happy to help with that since I've set it up in other places.
  • Tests are failing for coverage reasons. Instead of lowering the minimum threshold, we should maybe use "ignore this file" tags at the top of the specific files, or configure the suite to ignore the /lambdas/ directory.

@kdid kdid temporarily deployed to test October 13, 2023 15:18 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 13, 2023 15:28 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 13, 2023 15:30 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 13, 2023 18:06 — with GitHub Actions Inactive
@kdid kdid temporarily deployed to test October 13, 2023 18:48 — with GitHub Actions Inactive
Copy link
Contributor

@bmquinn bmquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dc_email

Looks great! 👍

@kdid kdid merged commit 05311a8 into deploy/staging Oct 16, 2023
2 checks passed
@kdid kdid deleted the 3292-3-av-download branch October 16, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants