Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors chat handler for easier configuration handling. #173

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Refactors chat handler for easier configuration handling. #173

merged 1 commit into from
Feb 5, 2024

Conversation

bmquinn
Copy link
Contributor

@bmquinn bmquinn commented Nov 16, 2023 •
edited
Loading

  • Refactors chat prototype configuration allowing clients to override more attributes like the deployment_name and version in the event payload sent to the API. Note: this refactor should be backwards-compatible and the existing prototype behavior should continue working without any changes.
  • Extracts functionality into files based on responsibility to make clearer code organization

Changes have already been deployed to the prototype-dev stack and can be tested in Postman.

@bmquinn bmquinn force-pushed the 4313-deployment-override branch 2 times, most recently from b18681f to 7666b58 Compare November 17, 2023 17:55
@bmquinn bmquinn marked this pull request as ready for review November 17, 2023 18:00
@bmquinn bmquinn requested review from mbklein and kdid November 17, 2023 18:02
mbklein
mbklein approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@mbklein mbklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice refactor! Great job turning all the janky proof-of-concept stuff into a real modular framework.

@bmquinn bmquinn force-pushed the 4313-deployment-override branch 2 times, most recently from 4487a89 to e50173f Compare February 2, 2024 03:30
@bmquinn
Allow for overriding parameters to the LLM with default configuration…
e667a7a 
… in place

- Large refactor of configuration handling, adds the ability to override many more parameters via websocket messages
- Tests passing in dev environment using the Makefile and Github actions
- Allow for skipping weaviate setup in Github actions via environment variable
@bmquinn bmquinn merged commit 1d7908a into deploy/prototype Feb 5, 2024
1 check passed
@bmquinn bmquinn deleted the 4313-deployment-override branch February 5, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbklein mbklein mbklein approved these changes

@kdid kdid Awaiting requested review from kdid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmquinn @mbklein