Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove add annotations workaround in IIIF response #182

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

adamjarling
Copy link
Contributor

What does this do?

In a IIIF API response:

  • Updates iiif-builder package to latest version, which includes support for applying annotations property onto a canvas.
  • Removes our manual workaround of applying annotations to a canvas

How to test

  • In the dev environment, identify (or create) a Work of "Video" type in your Meadow app which contains multiple Filesets.
  • In Meadow, under a Work's Structure tab, click "Edit Structure (VTT)" button and add some valid VTT code.
  • Inspect this Work directly in the DC API at http://localhost:3000/works/WORK_ID_HERE?as=iiif, and verify that the Fileset (canvas) with the above VTT has annotations` filled out.

Copy link
Contributor

@mbklein mbklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Looks good!

@adamjarling adamjarling force-pushed the 3344-vtt-annotations-use-builder branch from b96ef85 to e0f6592 Compare January 11, 2024 21:21
@adamjarling adamjarling merged commit 9cdd68b into deploy/staging Jan 11, 2024
2 checks passed
@adamjarling adamjarling deleted the 3344-vtt-annotations-use-builder branch January 11, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants