-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle DC Chat Feedback Submission #226
Conversation
b0ebabb
to
2b0df30
Compare
35dccef
to
0fb5f72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great as written. I think we should backtrack very slightly and change the chat-endpoint
and chat-feedback
routes to chat/endpoint
and chat/feedback
just to keep things organized. They're both undocumented private API routes, so it wouldn't be a major-version breaking change, and I really like the idea of keeping the routing table better segmented by function. (This will also make it a lot easier to split things up when we get around to #4518.)
It'll require a small simultaneous front-end update, but I very much think it's worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great to me. The one thing I saw is that it looks like you can send in the body without a context.ref, context.question, and/or a context.answer. Not sure if we want to bulletproof that more.
@mbklein and @mathewjordan - Addressed both of your comments. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary
Handle DC chat feedback submission.
Steps to Test
https://your-dev-branch-name.rdc-staging.library.northwestern.edu/api/v2/chat-feedback
route (You can use the Postan POST chat feedback endpoint (screenshot below)){your-dev-env}-chat-feedback
bucket and look for the response with a key of{sentiment}/{ref}.json