feat: Use bidirectional streaming for Source Transformer #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sreekanth <[email protected]>
BulkBeing
force-pushed
the
source-transformer-streaming
branch
from
f205113
to
99bdd08
Compare
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
vigith
approved these changes
Sep 27, 2024
yhl25
reviewed
Sep 30, 2024
Comment on lines
128
to
+134
| } | ||
| responseList := &v1.SourceTransformResponse{ | ||
| Results: results, | ||
|
|
||
| if err := grp.Wait(); err != nil { | ||
| statusErr := status.Errorf(codes.Internal, err.Error()) | ||
| return statusErr | ||
| } | ||
| return responseList, nil | ||
| return nil |
There was a problem hiding this comment.
if there is an error we will not let the client know until the stream is closed?
yhl25
reviewed
Sep 30, 2024
BulkBeing
force-pushed
the
source-transformer-streaming
branch
from
bd8cc00
to
301b46b
Compare
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
…aproj/numaflow-go into source-transformer-streaming
Fixed by using merge commit instead of rebasing. |
KeranYang
reviewed
Sep 30, 2024
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
yhl25
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of numaproj/numaflow#2046
Related PRs:
numaproj/numaflow#2071
numaproj/numaflow-rs#91