Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: container-type level version compatibility check #190

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

KeranYang
Copy link
Member

No description provided.

.
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
.
Signed-off-by: Keran Yang <[email protected]>
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 94.10%. Comparing base (a7434cf) to head (184282c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pynumaflow/sideinput/server.py 33.33% 2 Missing ⚠️
pynumaflow/sinker/server.py 33.33% 2 Missing ⚠️
pynumaflow/sourcer/server.py 33.33% 2 Missing ⚠️
pynumaflow/sourcetransformer/multiproc_server.py 33.33% 2 Missing ⚠️
pynumaflow/sourcetransformer/server.py 33.33% 2 Missing ⚠️
pynumaflow/mapper/multiproc_server.py 0.00% 1 Missing ⚠️
pynumaflow/mapper/sync_server.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   94.53%   94.10%   -0.43%     
==========================================
  Files          56       56              
  Lines        2213     2241      +28     
  Branches      131      131              
==========================================
+ Hits         2092     2109      +17     
- Misses         90      101      +11     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.
Signed-off-by: Keran Yang <[email protected]>
.
Signed-off-by: Keran Yang <[email protected]>
@KeranYang KeranYang marked this pull request as ready for review October 1, 2024 14:55
Comment on lines +116 to +119
serv_info = ServerInfo.get_default_server_info()
serv_info.minimum_numaflow_version = MINIMUM_NUMAFLOW_VERSION[
ContainerType.Sourcetransformer
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why tests are not covering it; it should be covered since there are no branches and the func is being called. interestingly it is happening everywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I am also curious about it. Some of the servers actually got covered, e.g., sink server. @kohlisid do you know why?

@KeranYang KeranYang merged commit 7180ce2 into numaproj:main Oct 1, 2024
10 of 11 checks passed
@kohlisid
Copy link
Contributor

kohlisid commented Oct 1, 2024

@KeranYang I see this got merged but to answer your question, in our code the server start utility would add the default server info automatically,

    if server_info is None:
        # Add the server information to the server info file
        # if not provided
        server_info = ServerInfo.get_default_server_info()

Only if a deviation from default was required we could pass a custom info object

cc @vigith

@vigith
Copy link
Member

vigith commented Oct 1, 2024

I am thinking whether we use the same pattern we used in Rust SDK.

@kohlisid
Copy link
Contributor

kohlisid commented Oct 1, 2024

We could have passed container type as parameter that can give the default with the requested one.
Will make a PR for any refactor that I can see

@KeranYang
Copy link
Member Author

thank you @kohlisid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants