chore: Remove the Metrics name dedup #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
|
I created the issue to add test case for the Prometheus push. We need to find the test library to test Prometheus abstraction. we need to refactor the code |
sarabala1979
commented
Mar 28, 2023
| for _, payload := range msgPayloads { | ||
| if _, ok := keys[payload.Name]; !ok { |
There was a problem hiding this comment.
name level dedub was removed
whynowy
reviewed
Mar 28, 2023
prometheus-pusher/main.go
Outdated
| return err | ||
| } | ||
| p.metrics.IncreaseTotalSuccess() | ||
| p.logger.Debug("Pushing Payload ", zap.Any("payload", payload)) |
| }) | ||
| appName := payload.Labels["app"] | ||
| p.metrics.IncreaseAnomalyGenerated(payload.Namespace, appName, payload.Name) | ||
| } |
Signed-off-by: Saravanan Balasubramanian <[email protected]>
whynowy
approved these changes
Mar 28, 2023
qhuai
reviewed
Mar 28, 2023
| } | ||
| p.metrics.IncreaseTotalSuccess() | ||
| p.logger.Debug("Pushing Payload ", zap.Any("payload", payload)) | ||
| pusher, err := p.createPusher(fmt.Sprintf("%s_%s_%s", payload.Namespace, payload.Subsystem, payload.Name)) |
There was a problem hiding this comment.
Just to double check: do we need to create a new pusher for each payload item?
| p.logger.Errorw("Unsupported Metrics Type", zap.Any("payload", payload)) | ||
| return fmt.Errorf("unsupported Metrics Type") | ||
| } | ||
| err = pusher.Push() |
There was a problem hiding this comment.
Just to double check: if a pusher needs an explicit close or such call.
| } | ||
| p.logger.Infow("Successfully pushed", zap.Any("payload", payload)) |
There was a problem hiding this comment.
would this infow() generate too many log lines in regular cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.