Enable custom metrics #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <[email protected]>
sarabala1979
requested review from
ab93,
nkoppisetty,
vigith and
s0nicboOm
as code owners
Signed-off-by: Avik Basu <[email protected]> Co-authored-by: Avik Basu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 86.23% 85.96% -0.28%
==========================================
Files 18 20 +2
Lines 1119 1154 +35
Branches 118 118
==========================================
+ Hits 965 992 +27
- Misses 130 138 +8
Partials 24 24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Saravanan Balasubramanian <[email protected]>
ab93
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
@sarabala1979 can you update the version in pyproject.toml. Otherwise LGTM
Signed-off-by: Saravanan Balasubramanian <[email protected]>
Signed-off-by: Avik Basu <[email protected]> Co-authored-by: Avik Basu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain what this PR does.