Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/refactor #388

Draft
wants to merge 70 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
4e50ba4
chore!: initial refactor (#381)
ab93 May 21, 2024
2970943
fix: add gru forecast models
ab93 May 21, 2024
8b03beb
fix: typing
ab93 May 22, 2024
f6ec6a5
fix tests for libs
ab93 May 29, 2024
e0e6700
first refactor
ab93 May 29, 2024
052bf86
app folder refactor
ab93 May 30, 2024
286d8d0
chore: numa-udf refactor
ab93 May 31, 2024
3e0aaba
feat: add dev containers to numa-udf
ab93 Jun 3, 2024
ec7d5be
chore: use requirements dir
ab93 Jun 4, 2024
8f03f33
chore: more refactor
ab93 Jun 4, 2024
9bae7bd
chore: add more requirements
ab93 Jun 4, 2024
2409368
fix: constants
ab93 Jun 4, 2024
574ed70
chore: remove comments
ab93 Jun 4, 2024
e03df9a
fix: log file
ab93 Jun 4, 2024
5d2be4d
chore: add precommit
ab93 Jun 4, 2024
71390ef
chore: github actions
ab93 Jun 6, 2024
9267119
fix workflow file
ab93 Jun 6, 2024
4bd78f6
fix workflow file
ab93 Jun 6, 2024
fafe46a
pip cache
ab93 Jun 6, 2024
a52ed60
fix: test run
ab93 Jun 6, 2024
ec60350
fix: connectors ci
ab93 Jun 6, 2024
49016bc
trying to fix tests
ab93 Jun 6, 2024
5b28c32
fix tests
ab93 Jun 6, 2024
c04daeb
wkflw: registry
ab93 Jun 6, 2024
101d175
wkflw: dependency fix
ab93 Jun 6, 2024
a1e5d63
wkflw: dependency fix
ab93 Jun 6, 2024
4f0bc9d
wkflw: lint
ab93 Jun 6, 2024
2ee3f36
wkflw: ruff version
ab93 Jun 6, 2024
8992df3
fix: ruff version
ab93 Jun 6, 2024
fffe0cc
wkfl: lint
ab93 Jun 6, 2024
ed54f8b
tmp test lint
ab93 Jun 6, 2024
ab68a6e
verbose
ab93 Jun 6, 2024
e54795a
tmp lint
ab93 Jun 6, 2024
afc5a01
fix lint
ab93 Jun 6, 2024
4814188
try lint
ab93 Jun 6, 2024
9b31bdb
files include
ab93 Jun 6, 2024
486d5e0
debug
ab93 Jun 6, 2024
290b05c
avoid ruff hook
ab93 Jun 6, 2024
f40a658
fix: lint for all libs
ab93 Jun 6, 2024
b7abb0a
fix: lint
ab93 Jun 6, 2024
e696bf0
fix: lint for connectors
ab93 Jun 6, 2024
3303a7d
fix: precommit
ab93 Jun 6, 2024
d106fb7
registry lint
ab93 Jun 6, 2024
e490097
wkflw: fix mkdocs
ab93 Jun 6, 2024
75a6cc5
try: coverage
ab93 Jun 7, 2024
348b4dc
try coverage fix
ab93 Jun 7, 2024
5a2bfc0
try coverage for all libs
ab93 Jun 7, 2024
baaa38f
try codecov fix
ab93 Jun 7, 2024
b9843d8
tmp try path
ab93 Jun 7, 2024
a40e2ce
tmp try
ab93 Jun 7, 2024
c493dc5
tmp: try
ab93 Jun 7, 2024
95f06b5
try numa udf builds
ab93 Jun 7, 2024
3ec0831
tmp: try subfolder
ab93 Jun 7, 2024
7b2ffbb
tmp pkg wheels
ab93 Jun 7, 2024
d088cb0
try fix docker build error
ab93 Jun 7, 2024
9cc9178
Merge branch 'main' into feat/refactor
ab93 Jun 13, 2024
6d88388
Merge branch 'main' into feat/refactor
ab93 Jun 13, 2024
1f7c75a
try: testpypi
ab93 Jun 13, 2024
6321f80
tmp: fix
ab93 Jun 13, 2024
4866d1f
tmp: test pypi publish for all
ab93 Jun 13, 2024
326dce0
try: dynamic version
ab93 Jun 13, 2024
7027f0d
use individual version
ab93 Jun 13, 2024
f7bb6a7
tmp: try publish
ab93 Jun 13, 2024
52d8e3e
tmp: try testpypi pkgs
ab93 Jun 13, 2024
0d59672
fix: dockerfiles
ab93 Jun 13, 2024
13db065
fix: orjson version
ab93 Jun 13, 2024
e28cc46
try: numa-udf coverage
ab93 Jun 13, 2024
7d0ef6f
fix: pynumaflow version
ab93 Jun 13, 2024
222a13f
fix: numa-udf coverage
ab93 Jun 13, 2024
b624da9
chore: add devcontainer ci
ab93 Jun 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions .github/workflows/apps.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: UDFs

on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]

jobs:
coverage:
name: coverage
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./apps/numa-udfs
steps:
- uses: actions/checkout@v4
- name: Install poetry
run: pipx install poetry==1.8

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.11
cache: 'poetry'

- name: Install dependencies
run: poetry install --no-root --with dev
- name: Run Coverage
run: |
poetry run pytest --cov-report=xml --cov=src --cov-config .coveragerc tests/ -sq

- name: Upload Coverage
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./coverage.xml
fail_ci_if_error: true
verbose: true
working-directory: ./apps/numa-udfs
name: numalogic-udfs

devcontainer:
name: coverage
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./apps/numa-udfs
steps:
- uses: actions/checkout@v4
- name: Build and run dev container task
uses: devcontainers/[email protected]
with:
subFolder: ./apps/numa-udfs
runCmd: pytest tests/
71 changes: 56 additions & 15 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,32 +7,73 @@ on:
branches: [ "main", "release/*" ]

jobs:
build:
name: Python version
numaloigic-core:
name: numalogic-core
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./libs/numalogic-core
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
python-version: ["3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v4

- name: Install poetry
run: pipx install poetry==1.6.1

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'poetry'

cache: 'pip'
- name: Install dependencies
run: |
poetry env use ${{ matrix.python-version }}
poetry install --all-extras --with dev
poetry run pip install "torch<3.0" -i https://download.pytorch.org/whl/cpu
poetry run pip install "pytorch-lightning<3.0"

- name: Test with pytest
pip install -r requirements/requirements.txt
pip install -r requirements/requirements-dev.txt
- name: Run tests
run: make test
numalogic-connectors:
name: numalogic-conectors
defaults:
run:
working-directory: ./libs/numalogic-connectors
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: [ "3.10", "3.11", "3.12"]
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
- name: Install dependencies
run: make setup
- name: Echo
run: pwd
- name: Run tests
run: make test
numalogic-registry:
name: numalogic-registry
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./libs/numalogic-registry
strategy:
fail-fast: false
matrix:
python-version: [ "3.10", "3.11", "3.12"]
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
- name: Install dependencies
working-directory: ./libs/numalogic-registry
run: make setup
- name: Run tests
working-directory: ./libs/numalogic-registry
run: make test
91 changes: 70 additions & 21 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,36 +7,27 @@ on:
branches: [ "main" ]

jobs:
build:
name: Codecov
numalogic-core:
name: numalogic-core
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ["3.9"]

defaults:
run:
working-directory: ./libs/numalogic-core
steps:
- uses: actions/checkout@v4

- name: Install poetry
run: pipx install poetry==1.6.1

- name: Set up Python ${{ matrix.python-version }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'poetry'

python-version: 3.9
cache: 'pip'
- name: Install dependencies
working-directory: ./libs/numalogic-core
run: |
poetry env use ${{ matrix.python-version }}
poetry install --all-extras --with dev
poetry run pip install "torch<3.0" -i https://download.pytorch.org/whl/cpu
poetry run pip install "pytorch-lightning<3.0"
pip install -r requirements/requirements.txt
pip install -r requirements/requirements-dev.txt

- name: Run Coverage
run: |
poetry run pytest --cov-report=xml --cov=numalogic --cov-config .coveragerc tests/ -sq
run: pytest --cov-report=xml --cov=numalogic --cov-config .coveragerc tests/ -sq

- name: Upload Coverage
uses: codecov/codecov-action@v4
Expand All @@ -45,3 +36,61 @@ jobs:
files: ./coverage.xml
fail_ci_if_error: true
verbose: true
working-directory: ./libs/numalogic-core
name: numalogic-core
numalogic-connectors:
name: numalogic-connectors
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./libs/numalogic-connectors
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9
cache: 'pip'
- name: Install dependencies
working-directory: ./libs/numalogic-connectors
run: make setup
- name: Run Coverage
run: pytest --cov-report=xml --cov=nlconnectors --cov-config .coveragerc tests/ -sq

- name: Upload Coverage
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./coverage.xml
fail_ci_if_error: true
verbose: true
working-directory: ./libs/numalogic-connectors
name: numalogic-connectors
numalogic-registry:
name: numalogic-registry
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./libs/numalogic-registry
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9
cache: 'pip'
- name: Install dependencies
working-directory: ./libs/numalogic-registry
run: make setup
- name: Run Coverage
run: pytest --cov-report=xml --cov=nlregistry --cov-config .coveragerc tests/ -sq

- name: Upload Coverage
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./coverage.xml
fail_ci_if_error: true
verbose: true
working-directory: ./libs/numalogic-registry
name: numalogic-registry
2 changes: 1 addition & 1 deletion .github/workflows/gh-pages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: 3.9
python-version: 3.11
- name: build
run: make docs
- name: deploy
Expand Down
60 changes: 53 additions & 7 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,66 @@ on:
branches: [ "main", "release/*" ]

jobs:
black:
name: Black format
numalogic-core:
name: numalogic-core
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./libs/numalogic-core
steps:
- uses: actions/checkout@v4
- uses: psf/black@stable
with:
options: "--check --verbose"
version: "~= 23.3"

ruff:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.11
cache: 'pip'
- name: Ruff
run: |
pip install ruff==0.4.7
ruff check -v .
numalogic-connectors:
name: numalogic-connectors
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./libs/numalogic-connectors
steps:
- uses: actions/checkout@v3
- uses: chartboost/ruff-action@v1
- uses: actions/checkout@v4
- uses: psf/black@stable
with:
options: "--check --verbose"
version: "~= 23.3"
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.11
cache: 'pip'
- name: Ruff
run: |
pip install ruff==0.4.7
ruff check -v .
numalogic-registry:
name: numalogic-registry
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./libs/numalogic-registry
steps:
- uses: actions/checkout@v4
- uses: psf/black@stable
with:
options: "--check --verbose"
version: "~= 23.3"
- name: Set up Python
uses: actions/setup-python@v5
with:
version: "0.0.275"
python-version: 3.11
cache: 'pip'
- name: Ruff
run: |
pip install ruff==0.4.7
ruff check -v .
Loading