Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Callback to the StateCache For Post Global Config Change #144

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shubhamdixit863
Copy link
Contributor

Yes

Fixes (#10)

Modifications

While initializing the LiveState Cache in the Init method, a callback is registered that calls the getCluster method to update the cache. This ensures that changes in configuration, such as includedResources and logLevel, are dynamically applied, keeping the cache current.

Verification

Todo

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.45%. Comparing base (926652a) to head (21b2e03).

Files Patch % Lines
internal/sync/cache.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   53.14%   52.45%   -0.69%     
==========================================
  Files          15       15              
  Lines        1543     1546       +3     
==========================================
- Hits          820      811       -9     
- Misses        595      608      +13     
+ Partials      128      127       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubhamdixit863 shubhamdixit863 marked this pull request as ready for review July 29, 2024 07:01
@juliev0
Copy link
Collaborator

juliev0 commented Jul 29, 2024

Hey @shubhamdixit863 - the code looks right, but did you do any testing? This issue is all about the testing - since this code involves the Numaflow Controller Rollout, can you check this procedure?:

  • Create NumaflowControllerRollout and see that the new child resources got created

  • Update "includedResources" in the file to add a new resource

  • Modify child Deployment "numaflow-controller" in some way and see if auto-healing works (might be okay if it doesn't but need to know)

  • Modify NumaflowControllerRollout to switch from version 1.2.1 to 1.1.7 (if you're merged with latest master you should be able to use 1.1.7 now due to this)

  • Update "includedResources" in the configmap to remove the new resource you added

  • Modify child Deployment "numaflow-controller" in some way and see if auto-healing works (might be okay if it doesn't but need to know)

  • Modify NumaflowControllerRollout to switch back to version 1.2.1

@xdevxy xdevxy marked this pull request as draft July 29, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants