Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isb service rollout test #48

Closed
wants to merge 15 commits into from
Closed

Isb service rollout test #48

wants to merge 15 commits into from

Conversation

a49ibrahim
Copy link
Contributor

Fixes #TODO

Modifications

Verification

afugazzotto and others added 15 commits June 6, 2024 14:40
@afugazzotto
works but not what I want
20d285f 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
closer
9aa1413 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
loaded numaflow CRDs to test suite
9208c74 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
Added more tests for PipelineRollout.
826a475 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
Fixed issue with envtest stop and adjusted pipelinerollout tests.
8565378 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
More test cases for pipeline rollout.
0d32395 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
Added deletion of pipeline rollout test case (WIP).
83ab39d 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
cleanup
394fd4c 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
deletion of pipeline
42aeb44 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
Added comments for findings, todos, and ideas.
d003e3c 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
tidy up
893356c 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
Using Numaflow Pipeline Spec instead of parsing JSON strings.
ba904fb 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
Added some unhappy cases.
80e8e17 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@afugazzotto
Addressed additional PR comments.
665071a 
Signed-off-by: Antonino Fugazzotto <[email protected]>
@a49ibrahim
feat: Add test for isbsservice
993908c 
Signed-off-by: Ali Ibrahim <[email protected]>
@a49ibrahim a49ibrahim closed this Jun 7, 2024
@a49ibrahim a49ibrahim deleted the isbServiceRolloutTest branch June 7, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdevxy xdevxy Awaiting requested review from xdevxy xdevxy will be requested when the pull request is marked ready for review xdevxy is a code owner

@juliev0 juliev0 Awaiting requested review from juliev0 juliev0 will be requested when the pull request is marked ready for review juliev0 is a code owner

@afugazzotto afugazzotto Awaiting requested review from afugazzotto afugazzotto will be requested when the pull request is marked ready for review afugazzotto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a49ibrahim @afugazzotto