fix a typo in the vector(list) function

numbas · Mar 8, 2024 · c4ca777 · c4ca777
1 parent 60531fd
commit c4ca777
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/runtime/scripts/jme-builtins.js b/runtime/scripts/jme-builtins.js
@@ -2216,8 +2216,8 @@ newBuiltin('vector',[sig.listof(sig.type('number'))],TVector, null, {
         var list = args[0];
         var value = list.value.map(function(x){return x.value});
         var t = new TVector(value);
-        if(args.length>0) {
-            var tn = args[0].value[0];
+        if(list.value.length>0) {
+            var tn = list.value[0];
             t.precisionType = tn.precisionType;
             t.precision = tn.precision;
         }

diff --git a/tests/jme-runtime.js b/tests/jme-runtime.js
@@ -16045,8 +16045,8 @@ newBuiltin('vector',[sig.listof(sig.type('number'))],TVector, null, {
         var list = args[0];
         var value = list.value.map(function(x){return x.value});
         var t = new TVector(value);
-        if(args.length>0) {
-            var tn = args[0].value[0];
+        if(list.value.length>0) {
+            var tn = list.value[0];
             t.precisionType = tn.precisionType;
             t.precision = tn.precision;
         }

diff --git a/tests/jme/jme-tests.mjs b/tests/jme/jme-tests.mjs
@@ -1148,6 +1148,10 @@ Numbas.queueScript('jme_tests',['qunit','jme','jme-rules','jme-display','jme-cal
         raisesNumbasError(assert, function() { new jme.types.TVector(1); }, 'jme.vector.value not an array of numbers');
         raisesNumbasError(assert, function() { new jme.types.TVector([1,[2],[3]]); }, 'jme.vector.value not an array of numbers');
         assert.ok(evaluate('matrix([i])'), 'complex values in matrices are OK');
+        assert.ok(evaluate('vector()'), 'empty vector');
+        assert.ok(evaluate('vector([])'), 'empty vector created with a list');
+        assert.ok(evaluate('matrix([])'), '0×0 matrix');
+        assert.ok(evaluate('matrix([[]])'), '1×0 matrix');
         assert.ok(evaluate('vector(i)'), 'complex values in vectors are OK');
         closeEqual(assert, evaluate('dot(vector(1,2),vector(2,3))').value,8,'dot(vector(1,2),vector(2,3))');
         closeEqual(assert, evaluate('dot(matrix([1],[2],[3]),vector(6,5,4))').value,28,'dot(matrix([1],[2],[3]),vector(6,5,4))');

diff --git a/tests/numbas-runtime.js b/tests/numbas-runtime.js
@@ -15636,8 +15636,8 @@ newBuiltin('vector',[sig.listof(sig.type('number'))],TVector, null, {
         var list = args[0];
         var value = list.value.map(function(x){return x.value});
         var t = new TVector(value);
-        if(args.length>0) {
-            var tn = args[0].value[0];
+        if(list.value.length>0) {
+            var tn = list.value[0];
             t.precisionType = tn.precisionType;
             t.precision = tn.precision;
         }