fix duplicate name error warning logic #821
Conversation
|
Thanks for this.
|
|
@christianp Around line 2005, I subscribed to the
Any additional feedback is welcomed. I can also remove the comments if you think they aren't necessary. |
|
@IsaacJrTypes Thanks. This isn't quite correct: it only sets the error message on the first I'll add some aesthetic comments to the code as well. |
| group.forEach(function(n) { | ||
| n.v.duplicateNameError(group.length > 1 ? n.name : null); | ||
| group.forEach(function (n) { | ||
| n.v.duplicateNameError(null); |
There was a problem hiding this comment.
While it won't noticeably affect performance, you can avoid having two nested forEach calls by setting n.v.duplicateNameError(null) when you loop over each name, instead of here where you're looping over names inside groups.
| @@ -771,20 +771,29 @@ $(document).ready(function() { | |||
|
|
|||
| // Finally, mark duplicate names | |||
| names.sort(Numbas.util.sortBy('name')); | |||
| var groupArray = []; | |||
There was a problem hiding this comment.
I don't think it's a good idea to include the type of a variable in its name. This could just be called groups.
| groupArray.forEach(function (group) { | ||
| var groupVariable = group[0]; | ||
| if (group.length > 1 && groupVariable.name != "") { | ||
| groupVariable.v.duplicateNameError(groupVariable.name); |
There was a problem hiding this comment.
You're only setting duplicateNameError on the first Variable in the group. You should set it for each variable in the group.
Again, groupVariable unnecessarily includes the type of the variable in its name. Just group will do.
The following code fixes the duplicate warning logic. Previously, the duplicate error logic would sort the names of the entries in the names input field, turn them into variable objects, and group them. Each group would be processed by the handle_group function, which would trigger updating the duplicateNameError knock-out observable if there more than 1 object in the group. The issue with this method is if the user inputs
a,b,a, theagroup would trigger the duplicateNameError function, but once thebgroup is processed, the duplicateNameError observable updates tonull.I used an object to track if there were any duplicates. Each time the user updates input names, a new object is created, and if there are duplicates, it returns the name error message.
