feat: redirect /home to /welcome when users are connected

numerique-gouv · Oct 6, 2023 · b7ec612 · b7ec612
1 parent f296c6a
commit b7ec612
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/web/flaskr/routes.py b/web/flaskr/routes.py
@@ -375,6 +375,8 @@ def index():
 
 @bp.route("/home")
 def home():
+    if has_user_session():
+        return redirect(url_for("routes.welcome"))
     is_rie = any(
         [
             IPAddress(request.remote_addr) in IPNetwork(network_ip)

diff --git a/web/tests/test_default.py b/web/tests/test_default.py
@@ -1,3 +1,6 @@
+from flask import url_for
+
+
 def test_root__anonymous_user(client_app):
     response = client_app.get("/", status=302)
 
@@ -32,10 +35,10 @@ def test_home__authenticated_user(client_app, mocker, authenticated_user):
     mocker.patch("flaskr.routes.get_meetings_stats", return_value=STATS)
 
     response = client_app.get(
-        "/home", extra_environ={"REMOTE_ADDR": "127.0.0.1"}, status=200
+        "/home", extra_environ={"REMOTE_ADDR": "127.0.0.1"}, status=302
     )
 
-    response.mustcontain("<!-- test page home -->")
+    assert response.location == url_for("routes.welcome")
 
 
 def test_change_language(client_app):