Skip to content

Commit

Permalink
Bug menu mobile (#150)
Browse files Browse the repository at this point in the history
* Cards: Add ratio management and fix the detail icon class

* Mobile menu: fix a consistency issue

* Update Python dependencies
  • Loading branch information
Ash-Crow authored Jun 19, 2024
1 parent 273de73 commit c18ad92
Show file tree
Hide file tree
Showing 5 changed files with 87 additions and 88 deletions.
2 changes: 1 addition & 1 deletion dsfr/templates/dsfr/header.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<div class="fr-header__navbar">
<button class="fr-btn--menu fr-btn"
data-fr-opened="false"
aria-controls="fr-modal-menu-mobile"
aria-controls="fr-menu-mobile"
id="fr-btn-menu-mobile"
title="{{ menu_label }}">
{{ menu_label }}
Expand Down
4 changes: 2 additions & 2 deletions dsfr/templatetags/dsfr_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ def dsfr_card(*args, **kwargs) -> dict:
- `fr-ratio-3x4`
- `fr-ratio-2x3`
A constant is provided for these classes in dsfr/constants.py: IMAGE_RATIOS
Constants are provided for these classes in dsfr/constants.py: IMAGE_RATIOS and VIDEO_RATIOS
Format of the top_detail dict (every field is optional):
Expand Down Expand Up @@ -1491,7 +1491,7 @@ def _render_alert_tag(message):
def dsfr_form(context: Context, form=None) -> dict:
"""
Returns the HTML for a form snippet
```python
data_dict = {
"form": an optionnal form to render instead of the form already present in context
Expand Down
2 changes: 1 addition & 1 deletion example_app/dsfr_components.py
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@
"extra_classes": "fr-link--download",
},
],
"doc_url": "https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/liens",
"doc_url": "https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/lien",
"example_url": "https://main--ds-gouv.netlify.app/example/component/link/",
},
"notice": {
Expand Down
Loading

0 comments on commit c18ad92

Please sign in to comment.