-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy requests to PostHog #165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebaudantoine
force-pushed
the
reverse-proxy
branch
2 times, most recently
from
September 23, 2024 10:21
72491f1
to
b3efabc
Compare
rouja
force-pushed
the
reverse-proxy
branch
9 times, most recently
from
September 23, 2024 16:05
3c3a51e
to
bcb17f9
Compare
lebaudantoine
force-pushed
the
reverse-proxy
branch
3 times, most recently
from
September 23, 2024 16:56
e8e3a48
to
4e3a6b0
Compare
rouja
force-pushed
the
reverse-proxy
branch
3 times, most recently
from
September 24, 2024 09:40
ecf1600
to
946b441
Compare
lebaudantoine
force-pushed
the
reverse-proxy
branch
3 times, most recently
from
September 24, 2024 22:05
7cfdefb
to
7bf940b
Compare
Proxy analytics requests through our backend to minimize ad-blockers impact. I configured the Helm Charts following PostHog official documentation.
Introduced by @rouja. Added a new linter to ensure helm and yaml files can be properly parsed into templates. ArgoCD can not break anymore.
Initial set-up errors. Fixed them. Removed unused Preprod environment, as secrets are not configured yet, it raises an error.
Fixed by @rouja. ArgoCD should be more robust than ever, while syncing with our code.
Inspired by Joanie. In Frontend context, env variables are only available at build time, not runtime. This is one of the easiest way to pass frontend dynamic configurations while running. This commit only exposes the view already existing.
Query API to get the App's configs. Replacement for env variables, thus with a single image, we can dynamically update frontend's behavior. Code inspired by Marsha. Not sure having a single component returning null is a good idea, to be discussed.
Declare the expected support and analytics env variables expected by the frontend for each environment. To avoid consuming too much credits from our PostHog free tier plan.
lebaudantoine
force-pushed
the
reverse-proxy
branch
from
September 25, 2024 08:44
c8ae68d
to
4a1eb7c
Compare
Based on feedback from @rouja, I've updated the Helm configuration for PostHog to use separate ingress resources for each service. Although the documentation suggests sharing the same ingress, the services have different externalName values, which conflicts with the use of a vhost in the ingress annotations. This change ensures proper service redirection by aligning each service with its own ingress.
lebaudantoine
force-pushed
the
reverse-proxy
branch
from
September 25, 2024 09:35
4a1eb7c
to
5fef14b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set-up a reverse proxy, to avoid ad blockers