🚸(frontend) generate shorter room IDs making URLs easier to share #42
Conversation
lebaudantoine
force-pushed
the
feature-41
branch
from
aeaed98
to
dd6d02f
Compare
|
I'm currently debating whether room ID validation should be handled on the frontend or backend side. While my last commit meets our short-term needs, introducing this 'lock' regex might pose issues in the long run. Addition of 'named' rooms would contradict my previous commit, as we'd only need to validate roomId formats for dynamically generated rooms. Again, we should discuss this further with Samuel. During my development, I noticed that passing an |
lebaudantoine
force-pushed
the
feature-41
branch
from
f5d991b
to
0dd5934
Compare
| import { slugify } from '@/utils/slugify' | ||
|
|
||
| const getRandomChar = () => { | ||
| // Google Meet uses only letters in a room identifier |
There was a problem hiding this comment.
so we officially are google-meet driven development huh? 😏
There was a problem hiding this comment.
We totally remove this mention if you feel it's weird
UUID-v4 room IDs are long and uninviting. Shorter, custom room IDs can enhance UX by making URLs easier to share and remember. While UUID-v4s are typically used in database systems for their low collision probability, for ephemeral room IDs, the collision risk of e+14 combinations is acceptable. This aligns room IDs with Google Meet format. Even if the 'slugify' function is not used anymore, I kept it. Lmk if you prefer removing it @manuhabitela
Good point, I'll change that |
Enhanced security by ensuring users are redirected to a 404 error page if they pass an incorrect roomId path, either intentionally or unintentionally. This is a critical security mechanism that should be included in our MVP. Let's discuss extracting hardcoded elements, such as lengths or the separator, into proper constants to improve code maintainability. I was concerned that this might make the code harder to read, it could enhance clarity and reusability in the long term. I prefer exposing the roomIdRegex from the same location where we generate IDs. However, this increases the responsibility of that file. Lmk if you have any suggestion for a better organization. Additionally, the current 404 error page displays a 'Page not found' message for invalid room IDs. Should we update this message to 'Invalid room name' to provide more context to the user?
- this feels a bit less boilerplaty to read - puting the characters whitelist outside the function to prevent creating the var each time (yes, this of super great importance)
|
Thanks! Allowed myself to rewrite a tiny bit the content of the small id generation functions to have a little less boilerplate. |
Proposition
Simplify room's name (ID).
Proposal
Please refer to the issue #41 which explains why simplifying room IDs could be beneficial in terms of user experience (UX).
It closes #41.