Language selector (adding new Popover primitives along the way) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easily use buttons toggling styled RAC popovers
this will be better in an options page later i think, as we don't pass our life changing language and we already have a language detector at load. this adds a PopoverList primitive to easily create buttons triggering popovers containing list of actionable items.
some focus rings were shown even when we only used the mouse. this globally fixes that
|
Allowing myself to merge as this contains a few interesting stuff (and I realized I already merged a thing in the i18n PR that should be in this 😬). Please comment here afterwards if you have any feedback, I'll handle it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a language selector in the header. Select the language you want through a new popover component.
I feel this will be better in a settings page later, but this will do for now!