Omit devDependencies again in fixtures workflow #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #718, the
fixtures.ymlworkflow broke when I added a call todotenvxin themigratescript, whiledotenvxwas only adevDependencywhich was not installed by that workflow. I "fixed" it by enablingdevDependenciesin that workflow.That was tragic mistake, as what that workflow failure was telling us was that the
migratescript was no longer able to run in a production-like environment.Fortunately, the problem was caught in the staging environment, and properly fixed in #760 by moving
dotenvxtodependencies.This PR completes the reversal by reinstating the
--omit-devflag in thefixtures.ymlworkflow, so that future similar issues are caught sooner.