Skip to content

Commit

Permalink
[NETTOYAGE] Supprime gestion cookie session devenue inutile
Browse files Browse the repository at this point in the history
Co-authored-by: Fabien Lamarque <[email protected]>
  • Loading branch information
egaillot and Fabinout committed May 23, 2024
1 parent 692cc4f commit 39aa889
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 81 deletions.
1 change: 0 additions & 1 deletion .env.oots.template
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
AVEC_ENVOI_COOKIE_SUR_HTTP= # autorise envoi du cookie de session par HTTP avec valeur true
AVEC_REQUETE_PIECE_JUSTIFICATIVE= # active l'API /requete/pieceJustificative avec valeur true
IDENTIFIANT_EIDAS= # identifiant eIDAS injecté dans les requêtes (tant qu'on ne sait pas le récupérer)
URL_OOTS_FRANCE= # URL Serveur OOTS-France, ex. https://oots.gouv.fr
Expand Down
62 changes: 0 additions & 62 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
},
"dependencies": {
"axios": "^1.6.0",
"cookie-session": "^2.1.0",
"express": "^4.19.2",
"fast-xml-parser": "^4.2.5",
"jose": "^5.2.0",
Expand Down
6 changes: 0 additions & 6 deletions src/adaptateurs/adaptateurEnvironnement.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
const avecEnvoiCookieSurHTTP = () => process.env.AVEC_ENVOI_COOKIE_SUR_HTTP === 'true';

const avecRequetePieceJustificative = () => process.env.AVEC_REQUETE_PIECE_JUSTIFICATIVE === 'true';

const identifiantEIDAS = () => process.env.IDENTIFIANT_EIDAS;

const secretJetonSession = () => new TextEncoder().encode(process.env.SECRET_JETON_SESSION);

module.exports = {
avecEnvoiCookieSurHTTP,
avecRequetePieceJustificative,
identifiantEIDAS,
secretJetonSession,
};
9 changes: 0 additions & 9 deletions src/ootsFrance.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
const cookieSession = require('cookie-session');
const express = require('express');
const mustacheExpress = require('mustache-express');

Expand All @@ -25,14 +24,6 @@ const creeServeur = (config) => {
app.set('view engine', 'mustache');
app.engine('mustache', mustacheExpress());

app.use(cookieSession({
maxAge: 15 * 60 * 1000,
name: 'session',
sameSite: true,
secret: adaptateurEnvironnement.secretJetonSession(),
secure: !adaptateurEnvironnement.avecEnvoiCookieSurHTTP(),
}));

app.use('/admin', routesAdmin({ ecouteurDomibus }));

app.use('/ebms', routesEbms({ adaptateurUUID, horodateur }));
Expand Down
2 changes: 0 additions & 2 deletions test/routes/serveurTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,8 @@ const serveurTest = () => {
};

adaptateurEnvironnement = {
avecEnvoiCookieSurHTTP: () => true,
avecRequetePieceJustificative: () => true,
identifiantEIDAS: () => 'FR/BE/123456789',
secretJetonSession: () => 'secret',
};

adaptateurUUID = {
Expand Down

0 comments on commit 39aa889

Please sign in to comment.