Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction objet métier TypeJustificatif #7

Merged
merged 2 commits into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/api/pieceJustificative.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const { ErreurAbsenceReponseDestinataire, ErreurReponseRequete, ErreurDestinataireInexistant } = require('../erreurs');
const TypeJustificatif = require('../ebms/typeJustificatif');

const urlRedirection = (idConversation, adaptateurDomibus) => adaptateurDomibus
.urlRedirectionDepuisReponse(idConversation)
Expand Down Expand Up @@ -29,14 +30,15 @@ const pieceJustificative = (
nomDestinataire,
previsualisationRequise,
} = requete.query;
const typeJustificatif = new TypeJustificatif({ id: idTypeJustificatif });

return depotPointsAcces.trouvePointAcces(nomDestinataire)
.then((destinataire) => adaptateurDomibus.envoieMessageRequete({
codeDemarche,
destinataire,
idConversation,
identifiantEIDAS: adaptateurEnvironnement.identifiantEIDAS(),
idTypeJustificatif,
typeJustificatif,
previsualisationRequise: (previsualisationRequise === 'true' || previsualisationRequise === ''),
}))
.then(() => Promise.any([
Expand Down
18 changes: 4 additions & 14 deletions src/ebms/requeteJustificatif.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const EnteteRequete = require('./enteteRequete');
const Message = require('./message');
const TypeJustificatif = require('./typeJustificatif');

class RequeteJustificatif extends Message {
static ClasseEntete = EnteteRequete;
Expand All @@ -11,15 +12,15 @@ class RequeteJustificatif extends Message {
destinataire = {},
idConversation = config.adaptateurUUID.genereUUID(),
identifiantEIDAS = 'DK/DE/123123123',
idTypeJustificatif = 'https://sr.oots.tech.ec.europa.eu/evidencetypeclassifications/oots/b6a49e54-8b3c-4688-acad-380440dc5962',
typeJustificatif = new TypeJustificatif({}),
previsualisationRequise = false,
} = {},
) {
super(config, { destinataire, idConversation });

this.codeDemarche = codeDemarche;
this.identifiantEIDAS = identifiantEIDAS;
this.idTypeJustificatif = idTypeJustificatif;
this.typeJustificatif = typeJustificatif;
this.previsualisationRequise = previsualisationRequise;
}

Expand Down Expand Up @@ -141,18 +142,7 @@ class RequeteJustificatif extends Message {
</sdg:Person>
</rim:SlotValue>
</rim:Slot>
<rim:Slot name="EvidenceRequest">
<rim:SlotValue xsi:type="rim:AnyValueType">
<sdg:DataServiceEvidenceType xmlns="urn:oasis:names:tc:ebxml-regrep:xsd:rim:4.0">
<sdg:Identifier>a8851d44-8f62-4561-99d2-5383ce3f30a7</sdg:Identifier>
<sdg:EvidenceTypeClassification>${this.idTypeJustificatif}</sdg:EvidenceTypeClassification>
<sdg:Title lang="EN">Diploma</sdg:Title>
<sdg:DistributedAs>
<sdg:Format>application/xml</sdg:Format>
</sdg:DistributedAs>
</sdg:DataServiceEvidenceType>
</rim:SlotValue>
</rim:Slot>
${this.typeJustificatif.enXML()}
</query:Query>
</query:QueryRequest>`;
}
Expand Down
32 changes: 32 additions & 0 deletions src/ebms/typeJustificatif.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
const FORMATS_DISTRIBUTION = {
FORMAT_PDF: 'application/pdf',
};

class TypeJustificatif {
constructor(donnees) {
const { id, descriptions, formatDistribution } = donnees;
this.id = id || 'https://sr.oots.tech.ec.europa.eu/evidencetypeclassifications/oots/00000000-0000-0000-0000-000000000000';
this.descriptions = descriptions;
this.formatDistribution = formatDistribution || FORMATS_DISTRIBUTION.FORMAT_PDF;
}

enXML() {
return `
<rim:Slot name="EvidenceRequest">
<rim:SlotValue xsi:type="rim:AnyValueType">
<sdg:DataServiceEvidenceType xmlns="urn:oasis:names:tc:ebxml-regrep:xsd:rim:4.0">
<sdg:Identifier>00000000-0000-0000-0000-000000000000</sdg:Identifier>
<sdg:EvidenceTypeClassification>${this.id}</sdg:EvidenceTypeClassification>
<sdg:Title lang="EN">${this.descriptions?.EN}</sdg:Title>
<sdg:DistributedAs>
<sdg:Format>${this.formatDistribution}</sdg:Format>
</sdg:DistributedAs>
</sdg:DataServiceEvidenceType>
</rim:SlotValue>
</rim:Slot>
`;
}
}

Object.assign(TypeJustificatif, FORMATS_DISTRIBUTION);
module.exports = TypeJustificatif;
4 changes: 2 additions & 2 deletions test/api/pieceJustificative.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ describe('Le requêteur de pièce justificative', () => {
it("transmet l'identifiant de type de pièce justificative demandée", () => {
requete.query.idTypeJustificatif = 'unIdentifiant';

adaptateurDomibus.envoieMessageRequete = ({ idTypeJustificatif }) => {
adaptateurDomibus.envoieMessageRequete = ({ typeJustificatif }) => {
try {
expect(idTypeJustificatif).toEqual('unIdentifiant');
expect(typeJustificatif.id).toEqual('unIdentifiant');
return Promise.resolve();
} catch (e) {
return Promise.reject(e);
Expand Down
3 changes: 2 additions & 1 deletion test/ebms/requeteJustificatif.spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const { parseXML, verifiePresenceSlot, valeurSlot } = require('./utils');
const RequeteJustificatif = require('../../src/ebms/requeteJustificatif');
const TypeJustificatif = require('../../src/ebms/typeJustificatif');

describe("La vue du message de requête d'un justificatif", () => {
const adaptateurUUID = {};
Expand Down Expand Up @@ -79,7 +80,7 @@ describe("La vue du message de requête d'un justificatif", () => {
it("injecte l'identifiant de type de justificatif demandé", () => {
const requeteJustificatif = new RequeteJustificatif(
configurationRequete,
{ idTypeJustificatif: 'unIdentifiant' },
{ typeJustificatif: new TypeJustificatif({ id: 'unIdentifiant' }) },
);
const xml = parseXML(requeteJustificatif.corpsMessageEnXML());

Expand Down
26 changes: 26 additions & 0 deletions test/ebms/typeJustificatif.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
const TypeJustificatif = require('../../src/ebms/typeJustificatif');

describe('Le type de justificatif', () => {
it("s'affiche en XML", () => {
const typeJustificatif = new TypeJustificatif({
id: 'unIdentifiant',
descriptions: { EN: 'someType' },
formatDistribution: TypeJustificatif.FORMAT_PDF,
});

expect(typeJustificatif.enXML()).toBe(`
<rim:Slot name="EvidenceRequest">
<rim:SlotValue xsi:type="rim:AnyValueType">
<sdg:DataServiceEvidenceType xmlns="urn:oasis:names:tc:ebxml-regrep:xsd:rim:4.0">
<sdg:Identifier>00000000-0000-0000-0000-000000000000</sdg:Identifier>
<sdg:EvidenceTypeClassification>unIdentifiant</sdg:EvidenceTypeClassification>
<sdg:Title lang="EN">someType</sdg:Title>
<sdg:DistributedAs>
<sdg:Format>application/pdf</sdg:Format>
</sdg:DistributedAs>
</sdg:DataServiceEvidenceType>
</rim:SlotValue>
</rim:Slot>
`);
});
});
Loading