Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 not supported by CI upgrade to Python 3.9 #76

Closed
mikofski opened this issue Dec 23, 2024 · 5 comments
Closed

Python 3.7 not supported by CI upgrade to Python 3.9 #76

mikofski opened this issue Dec 23, 2024 · 5 comments
Assignees

Comments

@mikofski
Copy link
Member

See https://github.com/numfocus/DISCOVER-Cookbook/pull/65/checks#step:3:6

@aterrel
Copy link
Member

aterrel commented Dec 23, 2024

I suggest upgrading to 3.13 so it doesn't fail again in 6 months

@aterrel
Copy link
Member

aterrel commented Dec 25, 2024

Okay looks like Python 3.13 isn't supported by Github yet, so used 3.12.8.

The workflows seems to be failing though for separate reasons:
preview: needs permission to deploy (see error log)
checklinks: is inconsistent in finding errors (see error log)

I propose we go ahead and accept #78, with the workflows switched to manual and create separate tickets for each workflow.

@aterrel aterrel self-assigned this Dec 25, 2024
@mikofski
Copy link
Member Author

needs permission to deploy

Is this only for rossjrw/pr-preview-action@v1? It used to work when we set it up. I don’t if relevant but the docs say:

grant actions permission to read and write to the repository…

This GitHub action just renders the Jupyter book from a PR to view it without having to build it locally offline. Convenient, but not 100% necessary.

@mikofski
Copy link
Member Author

I propose we go ahead and accept #78, with the workflows switched to manual and create separate tickets for each workflow.

Works for me

@aterrel
Copy link
Member

aterrel commented Dec 26, 2024

Merged #78 and created tickets for failing workflows.

@aterrel aterrel closed this as completed Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants