Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates github builder to 3.13 #78

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aterrel
Copy link
Member

@aterrel aterrel commented Dec 25, 2024

This patch updates the github workflow to use Python 3.

Reference: #76

@aterrel aterrel requested a review from a team December 25, 2024 14:43
@aterrel aterrel marked this pull request as ready for review December 25, 2024 14:44
Copy link
Member

@mikofski mikofski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR preview action should be limited to run only on pull requests.

I agree with this comment:

I propose we go ahead and accept #78, with the workflows switched to manual and create separate tickets for each workflow.

Let’s see if the build deploys, and the issues are only with the PR preview action which can be handled separately

@mikofski
Copy link
Member

Also does python version need downgrading to 3.12 in build actions well? Currently 3.13…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants