Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore some errors at module level #593

Merged
merged 4 commits into from
Dec 23, 2024
Merged

ignore some errors at module level #593

merged 4 commits into from
Dec 23, 2024

Conversation

lucascolley
Copy link
Contributor

@lucascolley lucascolley commented Dec 14, 2024 •
edited
Loading

closes gh-561

cc @stefanv

larsoner
larsoner approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny comment from me.

@stefanv did you want to look?

numpydoc/__main__.py Show resolved Hide resolved
@lucascolley
Copy link
Contributor Author

thanks @larsoner, addressed!

@stefanv stefanv merged commit dec2b9e into numpy:main Dec 23, 2024
25 of 26 checks passed
@stefanv
Copy link
Contributor

stefanv commented Dec 23, 2024

Thanks, Lucas!

@stefanv stefanv added this to the 1.9.0 milestone Dec 23, 2024
@lucascolley lucascolley deleted the gh-561 branch December 23, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner approved these changes

@stefanv stefanv stefanv approved these changes

Assignees
No one assigned
Labels
type: Enhancement
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

See Also missing reported for module level docstring
3 participants
@lucascolley @stefanv @larsoner