allow underscore assignments in node containers

nunnatsa · Mar 24, 2024 · 9724af7 · 9724af7
1 parent 97de4a9
commit 9724af7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/linter/ginkgo_linter.go b/linter/ginkgo_linter.go
@@ -239,7 +239,7 @@ func checkAssignments(pass *analysis.Pass, list []ast.Stmt) bool {
 		case *ast.AssignStmt:
 			for i, val := range st.Rhs {
 				if _, isFunc := val.(*ast.FuncLit); !isFunc {
-					if id, isIdent := st.Lhs[i].(*ast.Ident); isIdent {
+					if id, isIdent := st.Lhs[i].(*ast.Ident); isIdent && id.Name != "_" {
 						reportNoFix(pass, id.Pos(), useBeforeEachTemplate, id.Name)
 						foundSomething = true
 					}

diff --git a/testdata/src/a/vars-in-containers/all_containers.go b/testdata/src/a/vars-in-containers/all_containers.go
@@ -11,6 +11,8 @@ var _ = Describe("When's", func() {
 		shouldNotTriggerWarningEither = 2
 	)
 
+	_ = getValue()
+
 	When("test When", func() {
 		const shouldNotTriggerWarning = 3
 		const (

diff --git a/testdata/src/a/vars-in-containers/vars.go b/testdata/src/a/vars-in-containers/vars.go
@@ -10,6 +10,10 @@ type Human struct {
 	ID   string `json:"id"`
 }
 
+func getValue() int {
+	return 42
+}
+
 var _ = Describe("vars in Describe", func() {
 	var a = 1 // want `use BeforeEach\(\) to assign variable a`
 	var (
@@ -27,6 +31,8 @@ var _ = Describe("vars in Describe", func() {
 		g, h, valid2 int
 	)
 
+	_ = getValue()
+
 	if b == "testing" {
 		d = b // want `use BeforeEach\(\) to assign variable d`
 	} else {