Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve focus rule #105

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Improve focus rule #105

merged 1 commit into from
Aug 14, 2023

Conversation

nunnatsa
Copy link
Owner

Description

  1. Forbid also the usage of the Focus individual spec, e.g.
    It("test something", Focus, func(){
        Expect(...)...
    })
  2. Also forbid the FDescribeTable and the FEntry focused containers.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added test case and related test data
  • Update the functional test

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran golangci-lint

@nunnatsa

1. Forbid also the usage of the `Focus` individual spec, e.g.
    It("test something", Focus, func(){
        Expect(...)...
    })
2. Add `FDescribeTable` and `FEntry` to the forbiden containers.
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5852308387

  • 14 of 29 (48.28%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 83.982%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ginkgohandler/handler.go 2 17 11.76%
Totals Coverage Status
Change from base Build 5851657335: -1.0%
Covered Lines: 928
Relevant Lines: 1105

💛 - Coveralls

@nunnatsa nunnatsa merged commit 7fd98db into main Aug 14, 2023
1 check passed
@nunnatsa nunnatsa deleted the focus-spec branch August 14, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant