Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_picking_partner_ref: Migration to 17.0 #451

Open
wants to merge 14 commits into
base: 17.0
Choose a base branch
from

Conversation

deeniiz
Copy link
Collaborator

@deeniiz deeniiz commented Jan 16, 2025

No description provided.

@deeniiz deeniiz force-pushed the 17.0-mig-stock_picking_partner_ref branch from 508be3f to ae65ff8 Compare January 16, 2025 13:16
@deeniiz deeniiz requested review from eantones and FrankC013 January 17, 2025 09:46
Copy link
Member

@eantones eantones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!! :-)

@eantones
Copy link
Member

@FrankC013 can you please review?

@FrankC013
Copy link
Contributor

@eantones I have added a couple of changes to make. They don't affect the logic of the code but could be considered good practices or guidelines.

@eantones
Copy link
Member

@eantones I have added a couple of changes to make. They don't affect the logic of the code but could be considered good practices or guidelines.

Yes! Very good suggestions by the way :-)

@deeniiz deeniiz force-pushed the 17.0-mig-stock_picking_partner_ref branch from ae65ff8 to 28aa87a Compare January 22, 2025 12:23
Copy link
Contributor

@FrankC013 FrankC013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[MIG] stock_picking_partner: Migration to 17.0

[MIG] stock_picking_partner_ref: Migration to 17.0
@deeniiz deeniiz force-pushed the 17.0-mig-stock_picking_partner_ref branch from 28aa87a to c9053e5 Compare January 23, 2025 10:59
@deeniiz deeniiz requested review from eantones and FrankC013 January 23, 2025 12:06
Copy link
Contributor

@FrankC013 FrankC013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants