[nicljr] iP #369

nicljr · 2023-01-31T02:22:21Z

DukePro

"Your mind is for having ideas, not holding them." - David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here
double-click it
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

harin0826

Learnt a lot from your code! Just some suggestions to improve code quality. Thank you!! :)

harin0826 · 2023-02-02T14:30:48Z

src/main/java/duke/Ui.java

+import java.util.Scanner;
+
+public class Ui {
+    public static String HELLO = "Hello! I am Duke Nice To Meet You\n";


Could HELLO_MSG be more explanatory for this variable?

praveenkrishna0512

Overall, the code structure looks good! There were a few comments regarding following proper coding standards for naming. However, it is still a very good job done :)

praveenkrishna0512 · 2023-02-02T17:10:15Z

src/main/java/duke/TaskAssigner.java

+
+    public TaskAssigner() {}
+
+    public Task assignTask(String command) throws DukeException {


I like that your function name is written beginning with a verb! It helps to convey the action which the function is performing.

praveenkrishna0512 · 2023-02-02T17:11:38Z

src/main/java/duke/TaskAssigner.java

+    }
+
+    public Task assignEvent(String command) throws DukeException {
+        String[] splitTimings = command.split("/from | /to ");


May I clarify the intention behind the naming of this variable? Perhaps another name could be choosen to convey the message that the variable is an array of strings representing time (ie. timestampsAsString)

praveenkrishna0512 · 2023-02-02T17:13:10Z

src/main/java/duke/TaskAssigner.java

+            int s_index = command.indexOf("/from") + 6;
+            int e_index = command.indexOf("/to") + 4;
+            String start_date = TimeChecker.updateTime(command.substring(s_index, e_index - 5));
+            String end_date = TimeChecker.updateTime(command.substring(e_index));
+            String e_desc = command.substring(6, s_index - 6);


Not sure if I like the naming of these variables, as they do not follow camelCase.

praveenkrishna0512 · 2023-02-02T17:14:46Z

src/main/java/duke/Ui.java

+        System.out.println(HELLO);
+    }
+
+    public void bye() {


May I clarify the intention behind the naming of this function? Perhaps you could consider printBye() instead, so as to convey the action performed by the function.

praveenkrishna0512 · 2023-02-02T17:16:19Z

src/main/java/duke/tasks/Deadline.java

+public class Deadline extends Task {
+
+    static protected String DEFAULT_TIME = "2359";
+    protected LocalDateTime by;


Not sure if others will understand what the by variable represents on first look! Perhaps you could consider renaming it to dateBy so as to convey to others that it is a date!

…r Tasks

jedidiahC

Overall, I think most of your code following the Java coding standard!

But you may want to take note of the few instances where you used snake_case instead of camelCase for naming variables. These issues should be detected by using checkStyle.

Otherwise, the layout and statements seem to follow the coding standard. Good work!

jedidiahC · 2023-02-04T10:15:47Z

src/main/java/duke/TaskAssigner.java

            String d_desc = command.substring(9, d_index - 4);
-            return new Deadline(d_desc, deadline);
+            return new Deadline(d_desc, updated_deadline);


Might want to consider changing updated_deadline to updatedDeadline to adhere to the Java coding standard of naming variables in camelCase. I noticed that you used snake_case instead of camelCase in several other areas of your code as well. Might I suggest using checkStyle to detect such cases which could save you a lot of time instead of finding them manually.

jedidiahC · 2023-02-04T10:30:14Z

src/main/java/duke/Parser.java

+    public static String[] deadlineSplit(String deadline) {
+        return deadline.split(" ", 2);
+    }
+
+    public static String[] eventSplit(String event) {
+        return event.split(" ", 6);
+    }
+
+    public static LocalDateTime stringToDateTime(String duration) {
+        LocalDateTime localDateTime = LocalDateTime.parse(duration, strFormatter);
+        return localDateTime;
+    }
+
+    public static String dateTimeToString(LocalDateTime localDateTime) {


Should methods such as deadlineSplit be named something like splitDeadlineIntoStringArray to better follow the convention of naming methods using verbs?

jedidiahC · 2023-02-04T10:41:50Z

src/main/java/duke/Parser.java

+import java.time.LocalDateTime;
+import java.time.format.DateTimeFormatter;
+
+public class Parser {


Should Parser have a descriptive header comment?

jedidiahC · 2023-02-04T10:44:04Z

src/main/java/duke/Storage.java

+public class Storage {
+
+    public static String path = "DukeData/tasks.txt";
+    public static String dirPath = "DukeData";


Should this variable be converted to a constant?

jedidiahC · 2023-02-04T10:46:34Z

src/main/java/duke/Storage.java

+            Task curr = new Task("");
+
+            switch (text[0]) {
+                case ("T"):


Should the indentation for case clauses be removed to follow the coding standard?

Suggested change

case ("T"):

switch (text[0]) {

case ("T"):

jedidiahC · 2023-02-04T10:48:03Z

src/main/java/duke/Ui.java

+import java.util.ArrayList;
+
+public class Ui {
+    public static String GREET_MSG = "Hello! I am Duke Nice To Meet You\n";


Nice use of uppercase with underscores for naming the constants!

…an start date. An event with an end date canonot be earlier than the start date, this is to ensure that Duke catches this error and doesn't accept this invalid input. We want to ensure the correctness of our Tasks in Duke. Event constructor will throw a DukeException if such an input arrives, by utilising the LocalDateTime isBefore() method. Event holds the LocalDateTime information, hence one way I thought was to throw the Exception within the Event Class.

This reverts commit 35810a9.

Duke A-Assertions

This reverts commit 00bdbb8.

This reverts commit 3bceb3a.

Coding Standard needs to be adhered for clarity Removed Magic Numbers Ensured no Deep Nesteing, ArrowHead No long method names Ensure clarity of method names Done as suggested by the textbook provided

A-CodingStandard: Fix Coding Standards

…past week and Completed Task within the past week. Provided Insight on User Productivity through checking Urgency of various deadline tasks.

damithc and others added 17 commits July 31, 2022 17:20

Add Gradle support

556af3f

no message

df77119

Duke Level 2: Add, List

d6b8764

Duke Level 3 Mark As Done

c910988

Duke Level 4: ToDo, Deadline, Event

f2837d0

Duke: A-TextUiTesting

c26dc5f

Duke Level-5: Handle Errors

7fccd03

Duke Level 6: Delete

a7f039d

Duke Level-7: Save and Load

326442a

Duke Level 8: Dates and Times

722efb2

Duke A-MoreOOP: Use More OOP

b808016

no message

a29957d

no message

8adc44b

Merge remote-tracking branch 'origin/add-gradle-support'

a40eea4

Duke: A-Packages

1d74e99

Updated Commands and TaskList

8836d32

Fixed Dates and Times

45f7698

harin0826 reviewed Feb 2, 2023

View reviewed changes

praveenkrishna0512 reviewed Feb 2, 2023

View reviewed changes

nicljr added 4 commits February 3, 2023 02:01

Duke A-JUnit: Testing behaviour of Code + Updated Printing Methods fo…

45d6446

…r Tasks

Duke: A-JavaDoc

463ddac

Duke: A-CodingStandard

f4d424f

Duke Level-9: Find Command

fc0bd0a

jedidiahC reviewed Feb 4, 2023

View reviewed changes

nicljr added 6 commits February 6, 2023 15:42

Duke Level 10: Completeing JavaFX Tutorial

cf14b0c

Duke Level 10: GUI/ Updated Command and UI

27fff36

Duke A-CheckStyle

0b1488d

Duke A-Assertions

35810a9

Revert "Duke A-Assertions"

09b4513

This reverts commit 35810a9.

nicljr and others added 15 commits February 7, 2023 22:41

Duke A-Assertions

d6156b2

Merge pull request #1 from nicljr/A-Assertions

19c9546

Duke A-Assertions

Duke A-Jar: JAR File created for v0.2 upgraded from v0.1

be2ea3e

Duke Level-9: Making Find more specific

00bdbb8

Revert "Duke Level-9: Making Find more specific"

3bceb3a

This reverts commit 00bdbb8.

Revert "Revert "Duke Level-9: Making Find more specific""

86b6388

This reverts commit 3bceb3a.

A-CodingStandard: Fix Coding Standards

c13783f

Coding Standard needs to be adhered for clarity Removed Magic Numbers Ensured no Deep Nesteing, ArrowHead No long method names Ensure clarity of method names Done as suggested by the textbook provided

Merge pull request #3 from nicljr/A-CodeQuality

45b8a2d

A-CodingStandard: Fix Coding Standards

Duke C-Statistics: Provided Statistics on the added tasks within the …

dc82fb8

…past week and Completed Task within the past week. Provided Insight on User Productivity through checking Urgency of various deadline tasks.

Update README.md

e2d914c

Update README.md

489aa58

JavaDocs and CheckStyle

1532784

Merge branch 'master' of https://github.com/nicljr/ip

9684d05

Duke A-UserGuide

8cb19eb

JAR-Release Updates

4363e12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[nicljr] iP #369

[nicljr] iP #369

nicljr commented Jan 31, 2023 •

edited

Loading

harin0826 left a comment

harin0826 Feb 2, 2023

praveenkrishna0512 left a comment

praveenkrishna0512 Feb 2, 2023

praveenkrishna0512 Feb 2, 2023

praveenkrishna0512 Feb 2, 2023

praveenkrishna0512 Feb 2, 2023

praveenkrishna0512 Feb 2, 2023

jedidiahC left a comment

jedidiahC Feb 4, 2023

jedidiahC Feb 4, 2023

jedidiahC Feb 4, 2023

jedidiahC Feb 4, 2023 •

edited

Loading

jedidiahC Feb 4, 2023

jedidiahC Feb 4, 2023


		public TaskAssigner() {}

		public Task assignTask(String command) throws DukeException {

[nicljr] iP #369

Are you sure you want to change the base?

[nicljr] iP #369

Conversation

nicljr commented Jan 31, 2023 • edited Loading

DukePro

harin0826 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

praveenkrishna0512 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jedidiahC left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jedidiahC Feb 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicljr commented Jan 31, 2023 •

edited

Loading

jedidiahC Feb 4, 2023 •

edited

Loading