Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103-F10-3] MODcheck #138

Open
wants to merge 364 commits into
base: master
Choose a base branch
from

Conversation

joellow88
Copy link

MODcheck helps students keep track of their contacts for different modules. Students can have access to a database of modules, together with the module coordinators, and contacts of professors and TAs. Students will also be able to access more student-specific information such as consultation timeslots, professor’s linkedin, etc. This allows students to get access to help easier.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 48.78% and project coverage change: -11.53 ⚠️

Comparison is base (928f146) 72.15% compared to head (6e5aaaa) 60.63%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #138       +/-   ##
=============================================
- Coverage     72.15%   60.63%   -11.53%     
- Complexity      399      541      +142     
=============================================
  Files            70      108       +38     
  Lines          1232     2073      +841     
  Branches        125      218       +93     
=============================================
+ Hits            889     1257      +368     
- Misses          311      735      +424     
- Partials         32       81       +49     
Impacted Files Coverage Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø)
...n/java/seedu/address/commons/core/GuiSettings.java 69.23% <ø> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 51.72% <0.00%> (-23.28%) ⬇️
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <ø> (ø)
...eedu/address/logic/parser/ExportCommandParser.java 0.00% <0.00%> (ø)
.../seedu/address/logic/parser/ViewCommandParser.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
.../main/java/seedu/address/model/person/Address.java 80.00% <ø> (ø)
...odel/person/ContactContainsModuleTagPredicate.java 0.00% <0.00%> (ø)
... and 64 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

elvern18 and others added 29 commits March 15, 2023 22:50
…ddress

Fixes issue of undo and redo message showing "Address" instead of "Description".
Undo and Redo calls a few extra functions in ModelManager.
These functions are not originally part of the Model interface and had to be added.

The Model interface suffers from high coupling. Implementing the Model interface
 necessitates implementing the undo functionality, which may not be desirable.

Let's extract the undo functionality into an Undoable interface.
The ModelManager will implement both the Model and Undoable interface.

This allows future models to be developed without the need for undo functionality.
It also allows other objects to be marked undoable.
Add delete by multiple indexes functionality
Update use case for add, and include new use case for dark/light mode
create tests for DeleteMultipleIndexCommand
Enable assertions in build.gradle file
Update developer guide for undo command
update Dev Guide for DeleteMultiple command
Allow user to choose their favourite theme (Dark or light) for ModCheck
Statspadders and others added 30 commits April 10, 2023 20:57
Add JUnit test cases for light/dark commands
Update DG with more use cases for Undo
update index markdown file to show ModCheck
Fix UserGuide Table of content hyperlink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants