Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-W12-3] AssetBook #44

Open
wants to merge 684 commits into
base: master
Choose a base branch
from

Conversation

yisiox
Copy link

@yisiox yisiox commented Feb 20, 2024

AssetBook is a specialized application built upon AddressBook-3 for logistics and inventory managers to do contact and asset management. It is meant for those who wish to easily retrieve contact details based on contact or asset details.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 59.11602% with 74 lines in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (b896eb0) to head (d8a58fc).

Files with missing lines Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 29 Missing ⚠️
src/main/java/seedu/address/ui/CommandBox.java 0.00% 20 Missing ⚠️
...n/java/seedu/address/commons/core/GuiSettings.java 58.82% 6 Missing and 1 partial ⚠️
src/main/java/seedu/address/MainApp.java 0.00% 4 Missing ⚠️
.../main/java/seedu/address/logic/CommandHistory.java 85.00% 0 Missing and 3 partials ⚠️
...dress/commons/exceptions/DataLoadingException.java 0.00% 2 Missing ⚠️
...rc/main/java/seedu/address/logic/LogicManager.java 60.00% 2 Missing ⚠️
...ress/model/person/PersonMatchesQueryPredicate.java 89.47% 0 Missing and 2 partials ⚠️
.../seedu/address/storage/JsonAddressBookStorage.java 0.00% 2 Missing ⚠️
src/main/java/seedu/address/ui/UiManager.java 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
+ Coverage     75.26%   77.38%   +2.12%     
- Complexity      419      513      +94     
============================================
  Files            71       74       +3     
  Lines          1338     1605     +267     
  Branches        126      145      +19     
============================================
+ Hits           1007     1242     +235     
- Misses          301      335      +34     
+ Partials         30       28       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yisiox yisiox changed the title [CS2103T-W12-3] AssetBook3 [CS2103T-W12-3] AssetBook-3 Mar 29, 2024
yisiox and others added 28 commits April 4, 2024 02:49
aureliony and others added 25 commits April 15, 2024 21:15
…oding

Improve defensiveness of Logic and Model components
@yisiox yisiox changed the title [CS2103T-W12-3] AssetBook-3 [CS2103T-W12-3] AssetBook Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants