Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-T09-3] Elder Scrolls #58

Open
wants to merge 400 commits into
base: master
Choose a base branch
from

Conversation

chaaaaun
Copy link

Elder Scrolls is a contact list application that aids in befriending organisation management. It is optimised for CLI users to effortlessly manage volunteers, beneficiaries, and programs.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 78.39117% with 274 lines in your changes are missing coverage. Please review.

Project coverage is 76.98%. Comparing base (a9432f5) to head (a6b0c38).

❗ Current head a6b0c38 differs from pull request most recent head dfdb87d. Consider uploading reports for the commit dfdb87d to get more accurate results

Files Patch % Lines
src/main/java/scrolls/elder/ui/VolunteerCard.java 0.00% 35 Missing ⚠️
src/main/java/scrolls/elder/ui/BefriendeeCard.java 0.00% 34 Missing ⚠️
.../java/scrolls/elder/model/util/SampleDataUtil.java 3.22% 30 Missing ⚠️
...a/scrolls/elder/logic/commands/LogEditCommand.java 85.49% 7 Missing and 12 partials ⚠️
...va/scrolls/elder/logic/commands/LogAddCommand.java 78.94% 4 Missing and 12 partials ⚠️
src/main/java/scrolls/elder/ui/LogListPanel.java 0.00% 15 Missing ⚠️
src/main/java/scrolls/elder/ui/LogCard.java 0.00% 14 Missing ⚠️
...c/main/java/scrolls/elder/model/person/Person.java 71.42% 7 Missing and 3 partials ⚠️
src/main/java/scrolls/elder/MainApp.java 0.00% 9 Missing ⚠️
...scrolls/elder/logic/commands/LogDeleteCommand.java 85.93% 3 Missing and 6 partials ⚠️
... and 25 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #58      +/-   ##
============================================
+ Coverage     75.01%   76.98%   +1.97%     
- Complexity      500      760     +260     
============================================
  Files            78       98      +20     
  Lines          1669     2664     +995     
  Branches        183      304     +121     
============================================
+ Hits           1252     2051     +799     
- Misses          350      494     +144     
- Partials         67      119      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chaaaaun and others added 29 commits March 28, 2024 02:20
Refactor Storage and add Log functionality
Resolve Merge Conflicts resulting from refactoring of storage
Rename booleans for better clarity
Add added functionality to Find Command
Increase code coverage for both FindCommand
and FindCommandParser
The timeServed attribute is an int variable in Person which should only
be updated by LogAdd, LogEdit and LogDelete commands.
Improve test coverage for `model` package
Add Sequence Diagram for the Logic component of Pair
Update DeveloperGuide to include implementation of Pair feature
Update the diagrams and images involved in illustrating the undo and
redo mechanisms
The log edit command allows for a log previously added to be edited and
allows for the details in pre-existing logs to be updated.
Added functionality to search by Tags
Added testcases for FindCommandTest and Parser,
as well as new class TagListContainsTagsPredicate
Added functionality and testcases to support
--pair and --unpair flags in Find Command
Add `undo` and `redo` command functionality
CJerrong and others added 30 commits April 15, 2024 13:39
Update class diagrams in DG and edit UC02
Added appropriate signposting,
user-centric language, hyperlinks,
page breaks etc.
Update PPP header for all members
Replace `` with html inline code.
Rectify Typos
Fix typos and unclear parts
Fix typo
Fix bug
Documentation was added to some methods in the logadd, logedit and
logdelete classes. Variable names were refactored to maximise readability.
Improve code quality for command classes
Add logfind step to quickstart
Update DG use cases and add planned enhancement for duplicate detection.
Add cards to user interface
Fix exception messages displaying wrong information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants