Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-T13-2] InternBook #75

Open
wants to merge 427 commits into
base: master
Choose a base branch
from

Conversation

cocoanautz
Copy link

InternBook helps Computer Science students keep track of their internship application contacts. It is optimised for for CLI users so that tasks can be completed faster by typing.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 50.17921% with 139 lines in your changes are missing coverage. Please review.

Project coverage is 70.49%. Comparing base (7cec22c) to head (57ff3a1).

❗ Current head 57ff3a1 differs from pull request most recent head c45eae6. Consider uploading reports for the commit c45eae6 to get more accurate results

Files Patch % Lines
src/main/java/seedu/address/ui/ReminderWindow.java 0.00% 30 Missing ⚠️
.../seedu/address/logic/parser/SetReminderParser.java 0.00% 21 Missing ⚠️
...a/seedu/address/commons/core/ReminderSettings.java 42.85% 12 Missing ⚠️
...edu/address/logic/commands/SetReminderCommand.java 0.00% 11 Missing ⚠️
...in/java/seedu/address/model/reminder/Reminder.java 0.00% 10 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 8 Missing ⚠️
src/main/java/seedu/address/MainApp.java 0.00% 7 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 41.66% 7 Missing ⚠️
...rc/main/java/seedu/address/logic/LogicManager.java 25.00% 6 Missing ⚠️
...java/seedu/address/logic/commands/EditCommand.java 70.00% 1 Missing and 5 partials ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #75      +/-   ##
============================================
+ Coverage     69.02%   70.49%   +1.46%     
- Complexity      459      535      +76     
============================================
  Files            80       87       +7     
  Lines          1582     1786     +204     
  Branches        161      187      +26     
============================================
+ Hits           1092     1259     +167     
- Misses          426      459      +33     
- Partials         64       68       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jasperng-nus and others added 29 commits April 2, 2024 15:51
Change user guide format to a single html file to save space
Edit the storage to include storage of isMarked
- Modified handleExit() method in MainWindow to check and hide the ReminderWindow if it's open when the MainWindow is closed.

feat: Exclude companies marked as applied from ReminderWindow

- Updated fillInnerParts() method in ReminderWindow to filter out companies marked as applied from appearing in the reminder list.

fix: Update edit help message typo

- Corrected a minor typo in the edit help message.

feat: Display custom message when no companies to remind

- Modified fillInnerParts() method in ReminderWindow to display a custom message when there are no companies to remind.
Update edit command to work with dates
ReminderWindow is initialise and called show in UiManager.
Now:
ReminderWindow is initialise and called show in MainWindow.
'
jasperng-nus and others added 30 commits April 15, 2024 22:05
Update file names to fit github usernames
…-violation

Revert a Feature Freeze Violation PR #140
Add Mark and Unmark implementation and make some formatting adjustment
Add manual testing section in DG for all commands
…rCommand

Create test cases for reminder command
Fix bug on clicking image causing help menu to fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants