-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kok Bo Chang] iP #635
base: master
Are you sure you want to change the base?
[Kok Bo Chang] iP #635
Commits on Jul 11, 2024
-
damithc authored and damithc committed
Jul 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 68c58c1 - Browse repository at this point
Copy the full SHA 68c58c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03523ec - Browse repository at this point
Copy the full SHA 03523ecView commit details
Commits on Jul 21, 2024
-
build.gradle: Prevent generating a second JAR file
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
Configuration menu - View commit details
-
Copy full SHA for 81a9c53 - Browse repository at this point
Copy the full SHA 81a9c53View commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7e01237 - Browse repository at this point
Copy the full SHA 7e01237View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73fe471 - Browse repository at this point
Copy the full SHA 73fe471View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8feb9bd - Browse repository at this point
Copy the full SHA 8feb9bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e296f23 - Browse repository at this point
Copy the full SHA e296f23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83bec1a - Browse repository at this point
Copy the full SHA 83bec1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 003c59f - Browse repository at this point
Copy the full SHA 003c59fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4ccf38 - Browse repository at this point
Copy the full SHA d4ccf38View commit details -
Add different task types to be tracked
The original Task class is superseded by the ToDo, Deadline and Event classes. Lawrence.java is updated to handle the different task types accordingly.
Configuration menu - View commit details
-
Copy full SHA for a5f69a9 - Browse repository at this point
Copy the full SHA a5f69a9View commit details -
Add basic automated text UI testing
The single test case emulates user input and verifies that the Lawrence class responds correctly when fed a sequence of inputs. Ideally, more test cases should be incorporated in the future.
Configuration menu - View commit details
-
Copy full SHA for dce9306 - Browse repository at this point
Copy the full SHA dce9306View commit details -
Most user misinputs will be recognised by the program instead of crashing unexpectedly. The test has also been updated to include some faulty inputs.
Configuration menu - View commit details
-
Copy full SHA for 6e74ca5 - Browse repository at this point
Copy the full SHA 6e74ca5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d61db8 - Browse repository at this point
Copy the full SHA 8d61db8View commit details -
Add enums to handle different user commands
The enum class is also flexible enough to handle the capitalisation and partial capitalisation of commands.
Configuration menu - View commit details
-
Copy full SHA for 096fb10 - Browse repository at this point
Copy the full SHA 096fb10View commit details
Commits on Sep 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8b83b68 - Browse repository at this point
Copy the full SHA 8b83b68View commit details -
Add overloaded constructors to Task implementation
This change is to facilitate initialising tasks that may already be complete, which will be utilised when reading from the hard disk.
Configuration menu - View commit details
-
Copy full SHA for f612386 - Browse repository at this point
Copy the full SHA f612386View commit details -
Add statement to close scanner after use
Also renamed io methods for clarity
Configuration menu - View commit details
-
Copy full SHA for 9c8d9cb - Browse repository at this point
Copy the full SHA 9c8d9cbView commit details -
Separate logic for parsing file and user inputs
This will keep parsing logic localised and can be called accordingly depending on the source of the input
Configuration menu - View commit details
-
Copy full SHA for d455ca6 - Browse repository at this point
Copy the full SHA d455ca6View commit details -
Add factory class to handle parse method
The factory will call the relevant class to parse input strings depending on its source
Configuration menu - View commit details
-
Copy full SHA for 550c9d7 - Browse repository at this point
Copy the full SHA 550c9d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c20de3 - Browse repository at this point
Copy the full SHA 9c20de3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 617c7cf - Browse repository at this point
Copy the full SHA 617c7cfView commit details -
Integrate file saving with bot runtime
Also allows bot to initialise existing tasks on startup
Configuration menu - View commit details
-
Copy full SHA for 3d49f2d - Browse repository at this point
Copy the full SHA 3d49f2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e7edcb - Browse repository at this point
Copy the full SHA 6e7edcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c534c0b - Browse repository at this point
Copy the full SHA c534c0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8af860 - Browse repository at this point
Copy the full SHA d8af860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c3a80a - Browse repository at this point
Copy the full SHA 8c3a80aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 161b6d9 - Browse repository at this point
Copy the full SHA 161b6d9View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 16c1db0 - Browse repository at this point
Copy the full SHA 16c1db0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d103678 - Browse repository at this point
Copy the full SHA d103678View commit details -
Configuration menu - View commit details
-
Copy full SHA for 316ecc4 - Browse repository at this point
Copy the full SHA 316ecc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for aae8857 - Browse repository at this point
Copy the full SHA aae8857View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62dd75f - Browse repository at this point
Copy the full SHA 62dd75fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9960a6 - Browse repository at this point
Copy the full SHA f9960a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b97380 - Browse repository at this point
Copy the full SHA 4b97380View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa93129 - Browse repository at this point
Copy the full SHA fa93129View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45de8a5 - Browse repository at this point
Copy the full SHA 45de8a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2c24f7 - Browse repository at this point
Copy the full SHA a2c24f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46356d4 - Browse repository at this point
Copy the full SHA 46356d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5e9f74 - Browse repository at this point
Copy the full SHA c5e9f74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09c16b1 - Browse repository at this point
Copy the full SHA 09c16b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f1242d - Browse repository at this point
Copy the full SHA 0f1242dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12b18f7 - Browse repository at this point
Copy the full SHA 12b18f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e78e4b - Browse repository at this point
Copy the full SHA 1e78e4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2805de6 - Browse repository at this point
Copy the full SHA 2805de6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0093c6e - Browse repository at this point
Copy the full SHA 0093c6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aae3bdf - Browse repository at this point
Copy the full SHA aae3bdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f0109e - Browse repository at this point
Copy the full SHA 1f0109eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f07503 - Browse repository at this point
Copy the full SHA 9f07503View commit details -
Configuration menu - View commit details
-
Copy full SHA for 395c3cf - Browse repository at this point
Copy the full SHA 395c3cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 487dbcd - Browse repository at this point
Copy the full SHA 487dbcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8839695 - Browse repository at this point
Copy the full SHA 8839695View commit details -
Configuration menu - View commit details
-
Copy full SHA for 916d097 - Browse repository at this point
Copy the full SHA 916d097View commit details -
Configuration menu - View commit details
-
Copy full SHA for 213db3b - Browse repository at this point
Copy the full SHA 213db3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c66443a - Browse repository at this point
Copy the full SHA c66443aView commit details
Commits on Sep 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cbb6582 - Browse repository at this point
Copy the full SHA cbb6582View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6aec2d3 - Browse repository at this point
Copy the full SHA 6aec2d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1054af9 - Browse repository at this point
Copy the full SHA 1054af9View commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b2e0603 - Browse repository at this point
Copy the full SHA b2e0603View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b0c22e - Browse repository at this point
Copy the full SHA 5b0c22eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcec4f9 - Browse repository at this point
Copy the full SHA fcec4f9View commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7e00c82 - Browse repository at this point
Copy the full SHA 7e00c82View commit details -
Merge branch 'branch-Level-10'
The previous branch used to add javafx gui was add-gui, which was incorrectly named and not picked up by grading scripts. The proper branch branch-Level-10 was created with minimal commits with the sole intent of getting merged back into the master branch. Let's merge branch-Level-10 back into master, but leave the Level-10 tag as is so that the grading scripts mark the level 10 task as complete.
Configuration menu - View commit details
-
Copy full SHA for 317727a - Browse repository at this point
Copy the full SHA 317727aView commit details
Commits on Sep 15, 2024
-
Modify javadoc for TaskList::findTasks method
The current javadoc description for the method does not fully explain what instance fields the query matches when the method checks for a match. Changing the javadoc to specify that the description of the task is used for matching better explains the purse of the method. Let's modify the javadoc to specify that string matching is done with the task description to improve the documentation for the function.
Configuration menu - View commit details
-
Copy full SHA for 25e6700 - Browse repository at this point
Copy the full SHA 25e6700View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04a939e - Browse repository at this point
Copy the full SHA 04a939eView commit details -
Change behaviour of fromString method
The current implementation attempts to match the given input with the appriopriate CommandType enum value. If the input does not match any enum values, an IllegalArgumentException is thrown. This behaviour uses an exception for control flow, which should be avoided. Adding a special type to signify invalid command types might be a better way to handle bad inputs. Let's - Add an INVALID type for CommandType - Use the INVALID type as the default return value of CommandType::fromString
Configuration menu - View commit details
-
Copy full SHA for 262a452 - Browse repository at this point
Copy the full SHA 262a452View commit details -
Refactor bot's return values after commands
The current implementation for getResponse uses stores information about the previous executed command as a workaround for javafx components to access information about the executed command. This behaviour contributes to the temporary field code smell, as additional null checks need to be made if public methods are not called in the right order. Extracting out such information and placing them in a record class might be better to move data related to commands. Lets - Create a record object Response to store the data need by JavaFX for rendering - Refactor command objects to return a string response in the execute method instead of storing it as an instance variable to be accessed later - Clean up other parts of the program that require said data to use the Response record instead. - Remove unneeded instance fields that clutter the classes mentioned
Configuration menu - View commit details
-
Copy full SHA for abdb75b - Browse repository at this point
Copy the full SHA abdb75bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a16fe5 - Browse repository at this point
Copy the full SHA 6a16fe5View commit details -
Merge pull request #2 from C5hives/A-Streams
Modify javadoc for TaskList::findTasks method
Configuration menu - View commit details
-
Copy full SHA for 50849ba - Browse repository at this point
Copy the full SHA 50849baView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0f9b78 - Browse repository at this point
Copy the full SHA a0f9b78View commit details -
Configuration menu - View commit details
-
Copy full SHA for d27789e - Browse repository at this point
Copy the full SHA d27789eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3752c4 - Browse repository at this point
Copy the full SHA d3752c4View commit details -
Merge pull request #3 from C5hives/branch-A-Streams
Rephrase javadocs for TaskList::findTasks
Configuration menu - View commit details
-
Copy full SHA for 6093cde - Browse repository at this point
Copy the full SHA 6093cdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c67b5ca - Browse repository at this point
Copy the full SHA c67b5caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3af0d19 - Browse repository at this point
Copy the full SHA 3af0d19View commit details -
Merge pull request #4 from C5hives/branch-A-Assertions
Branch a assertions
Configuration menu - View commit details
-
Copy full SHA for adb6db1 - Browse repository at this point
Copy the full SHA adb6db1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95913dd - Browse repository at this point
Copy the full SHA 95913ddView commit details -
Merge pull request #5 from C5hives/branch-A-CodeQuality
Branch a code quality
Configuration menu - View commit details
-
Copy full SHA for 476b5b3 - Browse repository at this point
Copy the full SHA 476b5b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 955bc7a - Browse repository at this point
Copy the full SHA 955bc7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c338338 - Browse repository at this point
Copy the full SHA c338338View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f66473e - Browse repository at this point
Copy the full SHA f66473eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79d4ec3 - Browse repository at this point
Copy the full SHA 79d4ec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f27ba5 - Browse repository at this point
Copy the full SHA 0f27ba5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d31873c - Browse repository at this point
Copy the full SHA d31873cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d900777 - Browse repository at this point
Copy the full SHA d900777View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea1abaa - Browse repository at this point
Copy the full SHA ea1abaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71d005b - Browse repository at this point
Copy the full SHA 71d005bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7865e6 - Browse repository at this point
Copy the full SHA f7865e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6df19ef - Browse repository at this point
Copy the full SHA 6df19efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c853f4 - Browse repository at this point
Copy the full SHA 5c853f4View commit details
Commits on Sep 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6a6fd19 - Browse repository at this point
Copy the full SHA 6a6fd19View commit details