Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kok Bo Chang] iP #635

Open
wants to merge 91 commits into
base: master
Choose a base branch
from
Open

[Kok Bo Chang] iP #635

wants to merge 91 commits into from

Commits on Jul 11, 2024

  1. Add Gradle support

    damithc authored and damithc committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    68c58c1 View commit details
    Browse the repository at this point in the history
  2. Bump gradle and lib version

    Eclipse-Dominator authored and damithc committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    03523ec View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. build.gradle: Prevent generating a second JAR file

    In build.gradle, the dependencies on distZip and/or distTar causes
    the shadowJar task to generate a second JAR file for which the
    mainClass.set("seedu.duke.Duke") does not take effect.
    Hence, this additional JAR file cannot be run.
    For this product, there is no need to generate a second JAR file
    to begin with.
    
    Let's remove this dependency from the build.gradle to prevent the
    shadowJar task from generating the extra JAR file.
    aureliony authored and damithc committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    81a9c53 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    7e01237 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73fe471 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8feb9bd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e296f23 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    83bec1a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    003c59f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d4ccf38 View commit details
    Browse the repository at this point in the history
  8. Add different task types to be tracked

    The original Task class is superseded by the
    ToDo, Deadline and Event classes.
    
    Lawrence.java is updated to handle the different
    task types accordingly.
    C5hives committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a5f69a9 View commit details
    Browse the repository at this point in the history
  9. Add basic automated text UI testing

    The single test case emulates user input and verifies
    that the Lawrence class responds correctly when fed
    a sequence of inputs.
    
    Ideally, more test cases should be incorporated in
    the future.
    C5hives committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    dce9306 View commit details
    Browse the repository at this point in the history
  10. Add error messages for user

    Most user misinputs will be recognised by the program
    instead of crashing unexpectedly.
    
    The test has also been updated to include some faulty
    inputs.
    C5hives committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6e74ca5 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8d61db8 View commit details
    Browse the repository at this point in the history
  12. Add enums to handle different user commands

    The enum class is also flexible enough to handle
    the capitalisation and partial capitalisation of commands.
    C5hives committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    096fb10 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    8b83b68 View commit details
    Browse the repository at this point in the history
  2. Add overloaded constructors to Task implementation

    This change is to facilitate initialising tasks that
    may already be complete, which will be utilised when
    reading from the hard disk.
    C5hives committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f612386 View commit details
    Browse the repository at this point in the history
  3. Add statement to close scanner after use

    Also renamed io methods for clarity
    C5hives committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9c8d9cb View commit details
    Browse the repository at this point in the history
  4. Separate logic for parsing file and user inputs

    This will keep parsing logic localised and can be
    called accordingly depending on the source of the input
    C5hives committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d455ca6 View commit details
    Browse the repository at this point in the history
  5. Add factory class to handle parse method

    The factory will call the relevant class to parse
    input strings depending on its source
    C5hives committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    550c9d7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9c20de3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    617c7cf View commit details
    Browse the repository at this point in the history
  8. Integrate file saving with bot runtime

    Also allows bot to initialise existing tasks on startup
    C5hives committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3d49f2d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6e7edcb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c534c0b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d8af860 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8c3a80a View commit details
    Browse the repository at this point in the history
  13. Refactor command classes

    C5hives committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    161b6d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    16c1db0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'oop-refactor'

    C5hives committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d103678 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    316ecc4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aae8857 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    62dd75f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f9960a6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4b97380 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fa93129 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    45de8a5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a2c24f7 View commit details
    Browse the repository at this point in the history
  11. Add javadoc for Command.java

    C5hives committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    46356d4 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c5e9f74 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    09c16b1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0f1242d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    12b18f7 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1e78e4b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    2805de6 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    0093c6e View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    aae3bdf View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    1f0109e View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    9f07503 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    395c3cf View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    487dbcd View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    8839695 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    916d097 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    213db3b View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    c66443a View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Configuration menu
    Copy the full SHA
    cbb6582 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6aec2d3 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'A-CheckStyle'

    C5hives committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    1054af9 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    b2e0603 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b0c22e View commit details
    Browse the repository at this point in the history
  3. Merge branch 'add-gui'

    C5hives committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    fcec4f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    7e00c82 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'branch-Level-10'

    The previous branch used to add javafx gui was
    add-gui, which was incorrectly named and not
    picked up by grading scripts.
    
    The proper branch branch-Level-10 was created
    with minimal commits with the sole intent of
    getting merged back into the master branch.
    
    Let's merge branch-Level-10 back into master,
    but leave the Level-10 tag as is so that the
    grading scripts mark the level 10 task as
    complete.
    C5hives committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    317727a View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Modify javadoc for TaskList::findTasks method

    The current javadoc description for the
    method does not fully explain what instance
    fields the query matches when the method
    checks for a match.
    
    Changing the javadoc to specify that the
    description of the task is used for matching
    better explains the purse of the method.
    
    Let's modify the javadoc to specify that
    string matching is done with the task
    description to improve the documentation
    for the function.
    C5hives committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    25e6700 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    04a939e View commit details
    Browse the repository at this point in the history
  3. Change behaviour of fromString method

    The current implementation attempts to match
    the given input with the appriopriate CommandType
    enum value. If the input does not match any
    enum values, an IllegalArgumentException is thrown.
    
    This behaviour uses an exception for control flow,
    which should be avoided.
    
    Adding a special type to signify invalid command
    types might be a better way to handle bad inputs.
    
    Let's
    - Add an INVALID type for CommandType
    - Use the INVALID type as the default return value
    of CommandType::fromString
    C5hives committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    262a452 View commit details
    Browse the repository at this point in the history
  4. Refactor bot's return values after commands

    The current implementation for getResponse uses
    stores information about the previous executed
    command as a workaround for javafx components to
    access information about the executed command.
    
    This behaviour contributes to the temporary field
    code smell, as additional null checks need to be
    made if public methods are not called in the right
    order.
    
    Extracting out such information and placing them in
    a record class might be better to move data related
    to commands.
    
    Lets
    - Create a record object Response to store the data
    need by JavaFX for rendering
    - Refactor command objects to return a string response
    in the execute method instead of storing it as an instance
    variable to be accessed later
    - Clean up other parts of the program that require
    said data to use the Response record instead.
    - Remove unneeded instance fields that clutter the
    classes mentioned
    C5hives committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    abdb75b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6a16fe5 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #2 from C5hives/A-Streams

    Modify javadoc for TaskList::findTasks method
    C5hives authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    50849ba View commit details
    Browse the repository at this point in the history
  7. Revert "Merge pull request #2 from C5hives/A-Streams"

    This reverts commit 50849ba, reversing
    changes made to 317727a.
    C5hives committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    a0f9b78 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d27789e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d3752c4 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #3 from C5hives/branch-A-Streams

    Rephrase javadocs for TaskList::findTasks
    C5hives authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    6093cde View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c67b5ca View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3af0d19 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #4 from C5hives/branch-A-Assertions

    Branch a assertions
    C5hives authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    adb6db1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    95913dd View commit details
    Browse the repository at this point in the history
  15. Merge pull request #5 from C5hives/branch-A-CodeQuality

    Branch a code quality
    C5hives authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    476b5b3 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    955bc7a View commit details
    Browse the repository at this point in the history
  17. Update workflow.yml for CI

    C5hives committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    c338338 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    f66473e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    79d4ec3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0f27ba5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d31873c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d900777 View commit details
    Browse the repository at this point in the history
  6. Add screenshot of ui

    C5hives committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ea1abaa View commit details
    Browse the repository at this point in the history
  7. Update README

    C5hives committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    71d005b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f7865e6 View commit details
    Browse the repository at this point in the history
  9. Add more examples to README

    C5hives committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6df19ef View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5c853f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Configuration menu
    Copy the full SHA
    6a6fd19 View commit details
    Browse the repository at this point in the history