Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nihirraa] ip #643

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

[Nihirraa] ip #643

wants to merge 46 commits into from

Conversation

Nihirraa
Copy link

@Nihirraa Nihirraa commented Sep 4, 2024

Espresso☕

"I'm working late...coz I'm a coder"

Espresso is your task management chatbot that will help you:

• stay organized
• stay productive
• stay updated

Here's how you can use EspressoBot:

  1. Download it from here.
  2. Open the application.
  3. Start adding your tasks and deadlines!
  4. Let Espresso do the rest for you! ✨

"Isn't that sweet? I guess so"

Key Features:

  • Managing tasks
  • Managing deadlines (coming soon)
  • Notifications and reminders (coming soon)

To-Do List

  • Buy Textbooks
  • Organise shelf
  • Attend tp meeting
  • Buy Grocery

If you're familiar with Java, you can dive into the code and explore. Here's a snippet of the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

damithc and others added 11 commits July 11, 2024 16:52
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.

Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
Copy link

@currynia currynia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class names should start with capital letter

@@ -0,0 +1,12 @@
public class todoTask extends Task{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class name should start with capital letter

Copy link

@ChinSekYi ChinSekYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, your code are of good quality, I did not find much code quality issues. I have only raise up a few suggestions upon reviewing your code.

void addToList(String str) {
Task task = null;
try {
if (str.startsWith("todo")) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may change the if-statement indentation to indentation to once (4 spaces) instead of twice.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may rename your class to be capitalised at the first letter.

@@ -0,0 +1,14 @@
public class eventTask extends Task{
private String starts,ends;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may put a whitespace after the comma.

Suggested change
private String starts,ends;
private String starts, ends;

@KiKuasaurus
Copy link

Overall the code is well written without much issues, but perhaps javadoc could be added to make it easier to understand the purpose of each method and class.

Nihirraa and others added 13 commits September 17, 2024 02:43
Assertions were added to document important assumptions in the Espresso instance, user input, and bot response. These checks enhance code robustness.
- Enhanced conflict detection to prevent overlaps between EventTask and DeadlineTask.
- Conflict detection checks if a deadline occurs within the time span of an event.
- Throws an  when tasks with scheduling conflicts are detected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants