-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nihirraa] ip #643
base: master
Are you sure you want to change the base?
[Nihirraa] ip #643
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Class names should start with capital letter
src/main/java/todoTask.java
Outdated
@@ -0,0 +1,12 @@ | |||
public class todoTask extends Task{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class name should start with capital letter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, your code are of good quality, I did not find much code quality issues. I have only raise up a few suggestions upon reviewing your code.
src/main/java/Espresso.java
Outdated
void addToList(String str) { | ||
Task task = null; | ||
try { | ||
if (str.startsWith("todo")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may change the if-statement indentation to indentation to once (4 spaces) instead of twice.
src/main/java/deadlineTask.java
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may rename your class to be capitalised at the first letter.
src/main/java/eventTask.java
Outdated
@@ -0,0 +1,14 @@ | |||
public class eventTask extends Task{ | |||
private String starts,ends; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may put a whitespace after the comma.
private String starts,ends; | |
private String starts, ends; |
Overall the code is well written without much issues, but perhaps javadoc could be added to make it easier to understand the purpose of each method and class. |
Add A-Assertions Feature
Improve Code Quality
Add A-Streams Feature
Assertions were added to document important assumptions in the Espresso instance, user input, and bot response. These checks enhance code robustness.
- Enhanced conflict detection to prevent overlaps between EventTask and DeadlineTask. - Conflict detection checks if a deadline occurs within the time span of an event. - Throws an when tasks with scheduling conflicts are detected.
Espresso☕
Espresso is your task management chatbot that will help you:
• stay organized
• stay productive
• stay updated
Here's how you can use EspressoBot:
Key Features:
To-Do List
If you're familiar with Java, you can dive into the code and explore. Here's a snippet of the main method: